linux-kernel - Re: 回复: 回复: 回复: [PATCH v1 1/2] dt-bindings: media: starfive: Match driver and yaml property names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 28 Mar 2024 06:28:32 +0000
From: Conor Dooley <conor@...nel.org>
To: Changhuang Liang <changhuang.liang@...rfivetech.com>
CC: Conor Dooley <conor.dooley@...rochip.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Emil Renner Berthing <kernel@...il.dk>,
 Paul Walmsley <paul.walmsley@...ive.com>,
 Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
 Jack Zhu <jack.zhu@...rfivetech.com>,
 "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: 回复: 回复: 回复: [PATCH v1 1/2] dt-bindings: media: starfive: Match driver and yaml property names



On 28 March 2024 01:06:42 GMT, Changhuang Liang <changhuang.liang@...rfivetech.com> wrote:
>Hi, Conor,
>
>> On Mon, Jan 22, 2024 at 08:24:51AM +0000, Conor Dooley wrote:
>[...]
>> > > > > > Do these clocks etc exist but are not used by the driver?
>> > > > > >
>> > > > > > Or do they not exist at all?
>> > > > > >
>> > > > > > The two are very different!
>> > > >
>> > > > > These clocks etc exist but are not used by the driver.
>> > > >
>> > > > That's not an acceptable reason for removing them from the
>> > > > binding. If they exist, they should be documented, regardless of
>> > > > whether the driver makes use of them. NAK.
>> > >
>> > > If so, how to avoid the warning of dtbs_check.
>> >
>> > By also adding the clocks, resets and interrupts to the dts.
>> 
>> Going through patchwork stuff now that the merge window is done. I'm gonna
>> mark the dts patch as changes requeted. The binding (and dts) should
>> describe all of the clocks the hardware has, whether or not you choose to use
>> them all in software does not matter. Can you please resend the dts patch,
>> with all of the clocks, resets and interrupts present?
>> 
>
>You have applied the dts patch.
>https://lore.kernel.org/all/20240219032741.18387-1-changhuang.liang@starfivetech.com/

Oh, sorry for the noise then. I guess I was
mislead by patchwork marking this as new :)