linux-kernel - Re: [PATCH v3] scsi: libsas: Allocation SMP request is aligned to 16B

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZgUP_ZhWPxHQwZvl@infradead.org>
Date: Wed, 27 Mar 2024 23:36:45 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Yihang Li <liyihang9@...wei.com>
Cc: john.g.garry@...cle.com, yanaijie@...wei.com, jejb@...ux.ibm.com,
	martin.petersen@...cle.com, dlemoal@...nel.org,
	chenxiang66@...ilicon.com, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org, linuxarm@...wei.com,
	prime.zeng@...wei.com, yangxingui@...wei.com
Subject: Re: [PATCH v3] scsi: libsas: Allocation SMP request is aligned to 16B

> +	u8 *p = kzalloc(ALIGN(size, 16), GFP_KERNEL);

No, a magic undocumented 16 here max no sense at all.  See the
discussion on the previous iteration.