linux-kernel - Re: [PATCH v2] scsi: libsas: Allocation SMP request is aligned to ARCH_DMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZgUcTLQnoLuqhOxO@infradead.org>
Date: Thu, 28 Mar 2024 00:29:16 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Damien Le Moal <dlemoal@...nel.org>
Cc: Yihang Li <liyihang9@...wei.com>, Christoph Hellwig <hch@...radead.org>,
	John Garry <john.g.garry@...cle.com>, yanaijie@...wei.com,
	jejb@...ux.ibm.com, martin.petersen@...cle.com,
	chenxiang66@...ilicon.com, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org, linuxarm@...wei.com,
	prime.zeng@...wei.com, yangxingui@...wei.com
Subject: Re: [PATCH v2] scsi: libsas: Allocation SMP request is aligned to
 ARCH_DMA_MINALIGN

On Thu, Mar 28, 2024 at 04:23:22PM +0900, Damien Le Moal wrote:
> But I thought that the original issue was that some arch have ARCH_DMA_MINALIGN
> down to 8B but hisi driver needs at least 16 ?
> 
> So in the end, you need something like:
> 
> 	size = ALIGN(size, max(16, ARCH_DMA_MINALIGN));
> 
> no ?

I don't think we ever have an 8 byte dma minalign.  With 8-byte
aligned addresses dma_mapping_error could run into problems.