linux-kernel - Re: [PATCH] um: Add winch to winch_handlers before registering winch IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1743ad022502d64042fa7db4d847a988bb90cbdc.camel@sipsolutions.net>
Date: Thu, 28 Mar 2024 09:25:46 +0100
From: Johannes Berg <johannes@...solutions.net>
To: Roberto Sassu <roberto.sassu@...weicloud.com>, richard@....at, 
	anton.ivanov@...bridgegreys.com
Cc: linux-kernel@...r.kernel.org, linux-um@...ts.infradead.org, Roberto
 Sassu <roberto.sassu@...wei.com>
Subject: Re: [PATCH] um: Add winch to winch_handlers before registering
 winch IRQ

On Thu, 2024-03-07 at 11:49 +0100, Roberto Sassu wrote:
> From: Roberto Sassu <roberto.sassu@...wei.com>
> 
> Registering a winch IRQ is racy, an interrupt may occur before the winch is
> added to the winch_handlers list.
> 
> If that happens, register_winch_irq() adds to that list a winch that is
> scheduled to be (or has already been) freed, causing a panic later in
> winch_cleanup().
> 
> Avoid the race by adding the winch to the winch_handlers list before
> registering the IRQ, and rolling back if um_request_irq() fails.
> 

Reviewed-by: Johannes Berg <johannes@...solutions.net>

johannes