linux-kernel - Re: [PATCH] crypto: algboss: remove NULL check in cryptomgr_schedule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZgU/2p5Z3HwEdHz3@gondor.apana.org.au>
Date: Thu, 28 Mar 2024 18:00:58 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Roman Smirnov <r.smirnov@....ru>
Cc: "David S. Miller" <davem@...emloft.net>,
	Sergey Shtylyov <s.shtylyov@....ru>,
	Karina Yankevich <k.yankevich@....ru>, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH] crypto: algboss: remove NULL check in
 cryptomgr_schedule_probe()

On Wed, Mar 06, 2024 at 10:29:08AM +0300, Roman Smirnov wrote:
> The variable i will never be zero, so the check can be removed.
> 
> Found by Linux Verification Center (linuxtesting.org) with Svace.

Are you sure about this? It does not seem obvious that i cannot
be zero.  If the tool is correct you need to provide the reasoning
for it.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt