linux-kernel - Re: [PATCH 0/4] crypto: IAA stats bugfixes and simplifications

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZgVKECpfxpxyrzfR@gondor.apana.org.au>
Date: Thu, 28 Mar 2024 18:44:32 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Tom Zanussi <tom.zanussi@...ux.intel.com>
Cc: davem@...emloft.net, andre.glover@...ux.intel.com,
	linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
	dmaengine@...r.kernel.org
Subject: Re: [PATCH 0/4] crypto: IAA stats bugfixes and simplifications

On Mon, Mar 04, 2024 at 03:20:07PM -0600, Tom Zanussi wrote:
> Hi Herbert,
> 
> While doing some testing, I noticed a discrepancy in the
> decomp_bytes_in stat, which the first patch in this series (crypto:
> iaa - fix decomp_bytes_in stats) fixes.
> 
> I also realized that there were some other problems unrelated to that
> but also that the stats code could be simplified in a number of ways
> and that some of it wasn't really useful.  The stats code is debugging
> code and has been helpful to quickly verify whether things are
> basically working, but since it's there we should make it as accurate
> and actually useful as possible.
> 
> I realize the second patch (crypto: iaa - Remove comp/decomp delay
> statistics) removes the code I just fixed up in a patch you just
> merged (crypto: iaa - Fix comp/decomp delay statistics) - let me know
> if you want me to combine those if you want to remove the latter from
> your branch...
> 
> Thanks,
> 
> Tom
> 
> 
> *** BLURB HERE ***
> 
> Tom Zanussi (4):
>   crypto: iaa - fix decomp_bytes_in stats
>   crypto: iaa - Remove comp/decomp delay statistics
>   crypto: iaa - Add global_stats file and remove individual stat files
>   crypto: iaa - Change iaa statistics to atomic64_t
> 
>  .../driver-api/crypto/iaa/iaa-crypto.rst      |  76 +++++---
>  drivers/crypto/intel/iaa/iaa_crypto.h         |  16 +-
>  drivers/crypto/intel/iaa/iaa_crypto_main.c    |  13 +-
>  drivers/crypto/intel/iaa/iaa_crypto_stats.c   | 183 ++++++++----------
>  drivers/crypto/intel/iaa/iaa_crypto_stats.h   |   8 -
>  5 files changed, 140 insertions(+), 156 deletions(-)
> 
> -- 
> 2.34.1

All applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt