linux-kernel - Re: [PATCH] drm: DRM_WERROR should depend on DRM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 28 Mar 2024 13:11:06 +0200
From: Jani Nikula <jani.nikula@...el.com>
To: Geert Uytterhoeven <geert+renesas@...der.be>, Maarten Lankhorst
 <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
 Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>,
 Daniel Vetter <daniel@...ll.ch>, Hamza Mahfooz <hamza.mahfooz@....com>,
 Javier Martinez Canillas <javierm@...hat.com>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, Geert
 Uytterhoeven <geert+renesas@...der.be>
Subject: Re: [PATCH] drm: DRM_WERROR should depend on DRM

On Tue, 26 Mar 2024, Jani Nikula <jani.nikula@...el.com> wrote:
> On Tue, 26 Mar 2024, Geert Uytterhoeven <geert+renesas@...der.be> wrote:
>> There is no point in asking the user about enforcing the DRM compiler
>> warning policy when configuring a kernel without DRM support.
>>
>> Fixes: f89632a9e5fa6c47 ("drm: Add CONFIG_DRM_WERROR")
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
>
> D'oh! My bad.
>
> Reviewed-by: Jani Nikula <jani.nikula@...el.com>

And pushed to drm-misc-next. Thanks for the patch!

BR,
Jani.

>
>> ---
>>  drivers/gpu/drm/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
>> index f2bcf5504aa77679..2e1b23ccf30423a9 100644
>> --- a/drivers/gpu/drm/Kconfig
>> +++ b/drivers/gpu/drm/Kconfig
>> @@ -423,7 +423,7 @@ config DRM_PRIVACY_SCREEN
>>  
>>  config DRM_WERROR
>>  	bool "Compile the drm subsystem with warnings as errors"
>> -	depends on EXPERT
>> +	depends on DRM && EXPERT
>>  	default n
>>  	help
>>  	  A kernel build should not cause any compiler warnings, and this

-- 
Jani Nikula, Intel