linux-kernel - Re: [PATCH] lockdep: Use str_plural() to fix Coccinelle warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 28 Mar 2024 08:41:10 -0400
From: Waiman Long <longman@...hat.com>
To: Thorsten Blum <thorsten.blum@...lux.com>,
 Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
 Will Deacon <will@...nel.org>
Cc: Boqun Feng <boqun.feng@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lockdep: Use str_plural() to fix Coccinelle warning

On 3/28/24 06:09, Thorsten Blum wrote:
> Fixes the following Coccinelle/coccicheck warning reported by
> string_choices.cocci:
>
> 	opportunity for str_plural(depth)
>
> Signed-off-by: Thorsten Blum <thorsten.blum@...lux.com>
> ---
>   kernel/locking/lockdep.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
> index 151bd3de5936..31d7720c9b8d 100644
> --- a/kernel/locking/lockdep.c
> +++ b/kernel/locking/lockdep.c
> @@ -786,7 +786,7 @@ static void lockdep_print_held_locks(struct task_struct *p)
>   		printk("no locks held by %s/%d.\n", p->comm, task_pid_nr(p));
>   	else
>   		printk("%d lock%s held by %s/%d:\n", depth,
> -		       depth > 1 ? "s" : "", p->comm, task_pid_nr(p));
> +		       str_plural(depth), p->comm, task_pid_nr(p));
>   	/*
>   	 * It's not reliable to print a task's held locks if it's not sleeping
>   	 * and it's not the current task.
Acked-by: Waiman Long <longman@...hat.com>