linux-kernel - Re: [PATCH RFC 5/7] iio: frequency: admv1013: Use devm_regulator_get_enable_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 28 Mar 2024 13:51:40 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: David Lechner <dlechner@...libre.com>
Cc: Jonathan Corbet <corbet@....net>, Liam Girdwood <lgirdwood@...il.com>,
 Mark Brown <broonie@...nel.org>, Jean Delvare <jdelvare@...e.com>, Guenter
 Roeck <linux@...ck-us.net>, Support Opensource
 <support.opensource@...semi.com>, Cosmin Tanislav
 <cosmin.tanislav@...log.com>, Lars-Peter Clausen <lars@...afoo.de>, Michael
 Hennerich <Michael.Hennerich@...log.com>, Antoniu Miclaus
 <antoniu.miclaus@...log.com>, Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>, Dmitry Torokhov <dmitry.torokhov@...il.com>,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-hwmon@...r.kernel.org, linux-iio@...r.kernel.org,
 linux-staging@...ts.linux.dev, linux-input@...r.kernel.org
Subject: Re: [PATCH RFC 5/7] iio: frequency: admv1013: Use
 devm_regulator_get_enable_get_voltage()

On Wed, 27 Mar 2024 18:18:54 -0500
David Lechner <dlechner@...libre.com> wrote:

> We can reduce boilerplate code by using
> devm_regulator_get_enable_get_voltage().
> 
> The common mode voltage is now passed as a parameter in the init
> functions so we can avoid adding a state member that is only used
> during init.
> 
> Signed-off-by: David Lechner <dlechner@...libre.com>
LGTM - on basis this might not go through my tree

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>