linux-kernel - Re: [PATCH v11] platform/x86: add lenovo wmi camera button driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZgWKMUKmEhYtlyQ0@smile.fi.intel.com>
Date: Thu, 28 Mar 2024 17:18:09 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Hans de Goede <hdegoede@...hat.com>
Cc: 艾超 <aichao@...inos.cn>,
	"ilpo.jarvinen" <ilpo.jarvinen@...ux.intel.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	platform-driver-x86 <platform-driver-x86@...r.kernel.org>
Subject: Re: [PATCH v11] platform/x86: add lenovo wmi camera button driver

On Wed, Mar 27, 2024 at 09:03:38PM +0100, Hans de Goede wrote:
> On 3/27/24 2:14 PM, Andy Shevchenko wrote:
> > On Wed, Mar 27, 2024 at 11:54:55AM +0100, Hans de Goede wrote:
> >> On 3/26/24 3:54 AM, 艾超 wrote:

..

> >>>>> +config LENOVO_WMI_CAMERA
> >>>>> + tristate "Lenovo WMI Camera Button driver"
> >>>>> + depends on ACPI_WMI
> >>>>> + depends on INPUT
> >>>
> >>>> No COMPILE_TEST?
> >>>
> >>> I compile this driver and used Evtest tool to test it on lenovo A70.
> > 
> > What I meant here is to add respective COMPILE_TEST to the dependency(ies).
> 
> Neither include/linux/input.h nor include/linux/wmi.h offer
> stubs when disabled so this will not work.

Oh, I didn't realize that!

> Besides x86 has a lot of compile test coverage in general,
> so I don't see much value in adding || COMPILE_TEST to
> dependencies.

Agree.

-- 
With Best Regards,
Andy Shevchenko