linux-kernel - Re: [PATCH v5 2/2] ASoC: nau8325: new driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8278611a-a46f-4d5e-9861-67ff1084db50@sirena.org.uk>
Date: Thu, 28 Mar 2024 15:22:07 +0000
From: Mark Brown <broonie@...nel.org>
To: Seven Lee <wtli@...oton.com>
Cc: lgirdwood@...il.com, alsa-devel@...a-project.org,
	devicetree@...r.kernel.org, linux-sound@...r.kernel.org,
	krzysztof.kozlowski+dt@...aro.org, linux-kernel@...r.kernel.org,
	robh+dt@...nel.org, conor+dt@...nel.org, perex@...ex.cz,
	tiwai@...e.com, YHCHuang@...oton.com, KCHSU0@...oton.com,
	CTLIN0@...oton.com, SJLIN0@...oton.com, scott6986@...il.com,
	supercraig0719@...il.com, dardar923@...il.com
Subject: Re: [PATCH v5 2/2] ASoC: nau8325: new driver

On Wed, Mar 27, 2024 at 03:57:55PM +0800, Seven Lee wrote:

> +static const char * const nau8325_dac_oversampl[] = {
> +	"64", "256", "128", "", "32" };
> +
> +static const struct soc_enum nau8325_dac_oversampl_enum =
> +	SOC_ENUM_SINGLE(NAU8325_R29_DAC_CTRL1, NAU8325_DAC_OVERSAMPLE_SFT,
> +			ARRAY_SIZE(nau8325_dac_oversampl),
> +			nau8325_dac_oversampl);

This should really be a SOC_VALUE_ENUM so you can just hide the fourth
value rather than having the empty (presumably invalid) option.  Please
send an incremental patch doing this.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)