linux-kernel - Re: [PATCH] ASoC: ops: Fix wraparound for mask in snd_soc_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <171167574149.187137.12642574967939100311.b4-ty@kernel.org>
Date: Fri, 29 Mar 2024 01:29:01 +0000
From: Mark Brown <broonie@...nel.org>
To: lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.com, 
 Stephen Lee <slee08177@...il.com>
Cc: alsa-devel@...a-project.org, linux-kernel@...r.kernel.org, 
 linux-sound@...r.kernel.org, roman.gushchin@...ux.dev, dennis@...nel.org
Subject: Re: [PATCH] ASoC: ops: Fix wraparound for mask in
 snd_soc_get_volsw

On Mon, 25 Mar 2024 18:01:31 -0700, Stephen Lee wrote:
> In snd_soc_info_volsw(), mask is generated by figuring out the index of
> the most significant bit set in max and converting the index to a
> bitmask through bit shift 1. Unintended wraparound occurs when max is an
> integer value with msb bit set. Since the bit shift value 1 is treated
> as an integer type, the left shift operation will wraparound and set
> mask to 0 instead of all 1's. In order to fix this, we type cast 1 as
> `1ULL` to prevent the wraparound.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: ops: Fix wraparound for mask in snd_soc_get_volsw
      commit: fc563aa900659a850e2ada4af26b9d7a3de6c591

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark