linux-kernel - [tip: x86/fpu] x86/vm86: Make sure the free_vm86(task) definition uses its parameter even in the !CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <171171968134.10875.11841808669108375691.tip-bot2@tip-bot2>
Date: Fri, 29 Mar 2024 13:41:21 -0000
From: "tip-bot2 for Ingo Molnar" <tip-bot2@...utronix.de>
To: linux-tip-commits@...r.kernel.org
Cc:
 Ingo Molnar <mingo@...nel.org>, x86@...nel.org, linux-kernel@...r.kernel.org
Subject: [tip: x86/fpu] x86/vm86: Make sure the free_vm86(task) definition
 uses its parameter even in the !CONFIG_VM86 case

The following commit has been merged into the x86/fpu branch of tip:

Commit-ID:     5ca28d24aecd0809d93da2ea73a4f6e4b2ccfa78
Gitweb:        https://git.kernel.org/tip/5ca28d24aecd0809d93da2ea73a4f6e4b2ccfa78
Author:        Ingo Molnar <mingo@...nel.org>
AuthorDate:    Fri, 29 Mar 2024 14:20:40 +01:00
Committer:     Ingo Molnar <mingo@...nel.org>
CommitterDate: Fri, 29 Mar 2024 14:24:50 +01:00

x86/vm86: Make sure the free_vm86(task) definition uses its parameter even in the !CONFIG_VM86 case

I ran into a case in new code where free_vm86(task) was the only
consumer of the 'task' variable:

  arch/x86/kernel/process.c: In function ‘exit_thread’:
  arch/x86/kernel/process.c:118:31: error: unused variable ‘t’ [-Werror=unused-variable]

Robustify the definition in the !CONFIG_VM86 case.

Signed-off-by: Ingo Molnar <mingo@...nel.org>
Link: https://lore.kernel.org/r/ZgaFfyHMOdLHEKm+@gmail.com
---
 arch/x86/include/asm/vm86.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/include/asm/vm86.h b/arch/x86/include/asm/vm86.h
index 9e8ac50..62ee199 100644
--- a/arch/x86/include/asm/vm86.h
+++ b/arch/x86/include/asm/vm86.h
@@ -84,7 +84,7 @@ static inline int handle_vm86_trap(struct kernel_vm86_regs *a, long b, int c)
 
 static inline void save_v86_state(struct kernel_vm86_regs *a, int b) { }
 
-#define free_vm86(t) do { } while(0)
+#define free_vm86(task) do { (void)(task); } while(0)
 
 #endif /* CONFIG_VM86 */