linux-kernel - Re: [PATCH V6 net-next 3/4] net: hns3: dump more reg info based on ras mod

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 29 Mar 2024 08:15:01 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jijie Shao <shaojijie@...wei.com>
Cc: <yisen.zhuang@...wei.com>, <salil.mehta@...wei.com>,
 <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
 <jiri@...nulli.us>, <horms@...nel.org>, <rkannoth@...vell.com>,
 <shenjian15@...wei.com>, <wangjie125@...wei.com>, <liuyonglong@...wei.com>,
 <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V6 net-next 3/4] net: hns3: dump more reg info based on
 ras mod

On Fri, 29 Mar 2024 18:34:02 +0800 Jijie Shao wrote:
> > These seem to be duplicating standard stats from rtnl_link_stats64,
> > ethtool_pause_stats, ethtool_eth_mac_stats, etc.
> >
> > You can add device specific stats, but please don't duplicate
> > stats for which we have standard APIs.  
> 
> Yeah, but these are not duplicate stats for ethtool or debugfs.

Can you say more? I mean there are APIs to expose MIB counters.
Perhaps your driver doesn't implement those APIs today.
But (1) it should, and (2) once it does it will be a duplicate.

> Generally, driver will reset to restore the normal state.
> After the reset, many registers are cleared. Therefore,
> it is difficult to analyze the reason of RAS.

Perhaps I'm missing the significance of the reset when it comes
to counters reported via standard APIs. Are rtnl_link_stats64
going to behave differently across a reset than these debug entries?

> We wang to add this information only when RAS is occurring, And
> these information will help to analyze the reason of RAS.
> 
> these information does not appear in any new API.
> 
> Therefore, we hope that we can add this information to
> reduce the difficulty of analyzing certain issues.