[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240329-destruct-giggling-b27e373295ba@spud>
Date: Fri, 29 Mar 2024 15:40:57 +0000
From: Conor Dooley <conor@...nel.org>
To: keguang.zhang@...il.com
Cc: Vinod Koul <vkoul@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Huacai Chen <chenhuacai@...nel.org>, linux-mips@...r.kernel.org,
dmaengine@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 1/2] dt-bindings: dma: Add Loongson-1 APB DMA
On Fri, Mar 29, 2024 at 07:26:57PM +0800, Keguang Zhang via B4 Relay wrote:
> From: Keguang Zhang <keguang.zhang@...il.com>
>
> Add devicetree binding document for Loongson-1 APB DMA.
>
> Signed-off-by: Keguang Zhang <keguang.zhang@...il.com>
> ---
> Changes in v7:
> - Change the comptible to 'loongson,ls1*-apbdma' (suggested by Huacai Chen)
> - Update the title and description part accordingly
> - Rename the file to loongson,ls1b-apbdma.yaml
> - Add a compatible string for LS1A
> - Delete minItems of 'interrupts'
> - Change patterns of 'interrupt-names' to const
>
> Changes in v6:
> - Change the compatible to the fallback
> - Some minor fixes
>
> Changes in v5:
> - A newly added patch
> ---
> .../bindings/dma/loongson,ls1b-apbdma.yaml | 65 ++++++++++++++++++++++
> 1 file changed, 65 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/dma/loongson,ls1b-apbdma.yaml b/Documentation/devicetree/bindings/dma/loongson,ls1b-apbdma.yaml
> new file mode 100644
> index 000000000000..449da9fc2de1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dma/loongson,ls1b-apbdma.yaml
> @@ -0,0 +1,65 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/dma/loongson,ls1b-apbdma.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Loongson-1 APB DMA Controller
> +
> +maintainers:
> + - Keguang Zhang <keguang.zhang@...il.com>
> +
> +description:
> + Loongson-1 APB DMA controller provides 3 independent channels for
> + peripherals such as NAND, audio playback and capture.
> +
> +properties:
> + compatible:
> + oneOf:
> + - const: loongson,ls1b-apbdma
> + - items:
> + - enum:
> + - loongson,ls1a-apbdma
> + - loongson,ls1c-apbdma
> + - const: loongson,ls1b-apbdma
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + description: Each channel has a dedicated interrupt line.
If there's a respin, make this an items list. If you do, you can then
drop the maxItems and description. Ideally with that change made,
Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>
Thanks,
Conor.
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists