linux-kernel - Re: [PATCH] staging: rtl8192e: remove unnecessary wrapper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 29 Mar 2024 18:01:24 +0100
From: Philipp Hortmann <philipp.g.hortmann@...il.com>
To: Michael Straube <straube.linux@...il.com>, gregkh@...uxfoundation.org
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8192e: remove unnecessary wrapper

On 3/29/24 12:14, Michael Straube wrote:
> _rtl92e_dm_ctrl_initgain_byrssi() is just a wrapper around
> _rtl92e_dm_ctrl_initgain_byrssi_driver(). Using a wrapper here adds
> no value, remove it. Keep the name _rtl92e_dm_ctrl_initgain_byrssi().
> 
> Signed-off-by: Michael Straube <straube.linux@...il.com>
> ---
> Compile-tested only.
> 
>   drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 8 +-------
>   1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
> index 4c67bfe0e8ec..aebe67f1a46d 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
> @@ -163,7 +163,6 @@ static	void	_rtl92e_dm_check_tx_power_tracking(struct net_device *dev);
>   
>   static void _rtl92e_dm_dig_init(struct net_device *dev);
>   static void _rtl92e_dm_ctrl_initgain_byrssi(struct net_device *dev);
> -static void _rtl92e_dm_ctrl_initgain_byrssi_driver(struct net_device *dev);
>   static void _rtl92e_dm_initial_gain(struct net_device *dev);
>   static void _rtl92e_dm_pd_th(struct net_device *dev);
>   static void _rtl92e_dm_cs_ratio(struct net_device *dev);
> @@ -929,11 +928,6 @@ static void _rtl92e_dm_dig_init(struct net_device *dev)
>   		dm_digtable.rx_gain_range_min = DM_DIG_MIN;
>   }
>   
> -static void _rtl92e_dm_ctrl_initgain_byrssi(struct net_device *dev)
> -{
> -	_rtl92e_dm_ctrl_initgain_byrssi_driver(dev);
> -}
> -
>   /*-----------------------------------------------------------------------------
>    * Function:	dm_CtrlInitGainBeforeConnectByRssiAndFalseAlarm()
>    *
> @@ -952,7 +946,7 @@ static void _rtl92e_dm_ctrl_initgain_byrssi(struct net_device *dev)
>    *
>    ******************************************************************************/
>   
> -static void _rtl92e_dm_ctrl_initgain_byrssi_driver(struct net_device *dev)
> +static void _rtl92e_dm_ctrl_initgain_byrssi(struct net_device *dev)
>   {
>   	struct r8192_priv *priv = rtllib_priv(dev);
>   	u8 i;

Tested-by: Philipp Hortmann <philipp.g.hortmann@...il.com>