linux-kernel - Re: [PATCH 0/4] perf annotate: Use libcapstone as a disasssembler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zgb1uj_VQ1pjFdKE@x1>
Date: Fri, 29 Mar 2024 14:09:41 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Namhyung Kim <namhyung@...nel.org>
Cc: Ian Rogers <irogers@...gle.com>, Kan Liang <kan.liang@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
	linux-perf-users@...r.kernel.org,
	Changbin Du <changbin.du@...wei.com>
Subject: Re: [PATCH 0/4] perf annotate: Use libcapstone as a disasssembler

On Thu, Mar 28, 2024 at 04:20:05PM -0700, Namhyung Kim wrote:
> Hello,
> 
> As we've added libcapstone support, it's natural to use it for perf annotate
> as well.  This change added the capstone support on x86 first.  Other archs
> can be added later (by someone who can verify it doesn't break things).
> 
> For now it tries to use capstone (if available) before objdump.  But it
> doesn't support source file and line number info.  So users should use the
> objdump (by passing --objdump=PATH option) if they need them.  For example,
> this command line will keep the existing behavior (i.e. using objdump).
> 
>   # not to use capstone for disassembly
>   $ perf annotate --objdump=objdump
> 
> The capstone uses LLVM objdump style output which is slightly different than
> the GNU objdump.  But it should not have differences besides that.  I've
> verified the result of data type profiling and it produced the same output
> but gave me ~3x speedups.

Excellent news, I'll try and test all this soon!

- Arnaldo