linux-kernel - Re: [PATCH 1/6] wifi: ath10k: sdio: simplify module initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f78fa061-3b34-47d2-a40c-bbec744f0f97@quicinc.com>
Date: Fri, 29 Mar 2024 10:22:00 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Kalle Valo
	<kvalo@...nel.org>, Jeff Johnson <jjohnson@...nel.org>,
        Brian Norris
	<briannorris@...omium.org>,
        Ajay Singh <ajay.kathat@...rochip.com>,
        Claudiu
 Beznea <claudiu.beznea@...on.dev>,
        <linux-wireless@...r.kernel.org>, <ath10k@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/6] wifi: ath10k: sdio: simplify module initialization

On 3/29/2024 10:10 AM, Krzysztof Kozlowski wrote:
> This driver's initialization functions do not perform any custom code,
> except printing messages.  Printing messages on modules
> loading/unloading is discouraged because it pollutes the dmesg
> regardless whether user actually has this device.  Core kernel code
> already gives tools to investigate whether module was loaded or not.
> 
> Drop the printing messages which allows to replace open-coded
> module_sdio_driver().
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Acked-by: Jeff Johnson <quic_jjohnson@...cinc.com>

> 
> ---
> 
> FYI:
> I have ongoing patchset touching few lines above this patch chunk
> (sdio_driver) which might go via different tree. If that patchset is
> applied via different tree, it might result in a trivial conflict, but
> there is no dependency. They can go via separate trees (except that
> trivial conflict).

I'll let Kalle respond if he'll take this through the ath tree vs letting you
take it through your tree