linux-kernel - Re: [PATCH v0 02/14] drm/amdgpu,drm/radeon: Make I2C terminology more inclusive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zgb8gieDzZtZmg2q@ashyti-mobl2.lan>
Date: Fri, 29 Mar 2024 18:38:10 +0100
From: Andi Shyti <andi.shyti@...ux.intel.com>
To: Easwar Hariharan <eahariha@...ux.microsoft.com>
Cc: Andi Shyti <andi.shyti@...ux.intel.com>,
	Alex Deucher <alexander.deucher@....com>,
	Christian König <christian.koenig@....com>,
	"Pan, Xinhui" <Xinhui.Pan@....com>,
	David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
	Harry Wentland <harry.wentland@....com>,
	Leo Li <sunpeng.li@....com>,
	Rodrigo Siqueira <Rodrigo.Siqueira@....com>,
	Evan Quan <evan.quan@....com>,
	Hawking Zhang <Hawking.Zhang@....com>,
	Candice Li <candice.li@....com>, Ran Sun <sunran001@...suo.com>,
	Alexander Richards <electrodeyt@...il.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	Neil Armstrong <neil.armstrong@...aro.org>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Hamza Mahfooz <hamza.mahfooz@....com>,
	Ruan Jinjie <ruanjinjie@...wei.com>, Alan Liu <haoping.liu@....com>,
	Aurabindo Pillai <aurabindo.pillai@....com>,
	Wayne Lin <wayne.lin@....com>, Samson Tam <samson.tam@....com>,
	Alvin Lee <alvin.lee2@....com>, Charlene Liu <charlene.liu@....com>,
	Sohaib Nadeem <sohaib.nadeem@....com>,
	Lewis Huang <lewis.huang@....com>,
	Tom Chung <chiahsuan.chung@....com>,
	Bhawanpreet Lakha <Bhawanpreet.Lakha@....com>,
	Meenakshikumar Somasundaram <meenakshikumar.somasundaram@....com>,
	George Shen <george.shen@....com>, Aric Cyr <aric.cyr@....com>,
	Jun Lei <jun.lei@....com>,
	Nicholas Kazlauskas <nicholas.kazlauskas@....com>,
	Qingqing Zhuo <Qingqing.Zhuo@....com>,
	Dillon Varone <dillon.varone@....com>, Le Ma <Le.Ma@....com>,
	Lijo Lazar <lijo.lazar@....com>, Asad kamal <asad.kamal@....com>,
	Kenneth Feng <kenneth.feng@....com>, Ma Jun <Jun.Ma2@....com>,
	Mario Limonciello <mario.limonciello@....com>,
	Yang Wang <kevinyang.wang@....com>,
	Darren Powell <darren.powell@....com>,
	Yifan Zhang <yifan1.zhang@....com>,
	"open list:RADEON and AMDGPU DRM DRIVERS" <amd-gfx@...ts.freedesktop.org>,
	"open list:DRM DRIVERS" <dri-devel@...ts.freedesktop.org>,
	open list <linux-kernel@...r.kernel.org>,
	Wolfram Sang <wsa+renesas@...g-engineering.com>,
	"open list:INTEL DRM DISPLAY FOR XE AND I915 DRIVERS" <intel-gfx@...ts.freedesktop.org>,
	"open list:INTEL DRM DISPLAY FOR XE AND I915 DRIVERS" <intel-xe@...ts.freedesktop.org>,
	"open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS" <nouveau@...ts.freedesktop.org>,
	"open list:I2C SUBSYSTEM HOST DRIVERS" <linux-i2c@...r.kernel.org>,
	"open list:BTTV VIDEO4LINUX DRIVER" <linux-media@...r.kernel.org>,
	"open list:FRAMEBUFFER LAYER" <linux-fbdev@...r.kernel.org>,
	Andi Shyti <andi.shyti@...nel.org>
Subject: Re: [PATCH v0 02/14] drm/amdgpu,drm/radeon: Make I2C terminology
 more inclusive

Hi,

On Fri, Mar 29, 2024 at 10:28:14AM -0700, Easwar Hariharan wrote:
> On 3/29/2024 10:16 AM, Andi Shyti wrote:
> > Hi Easwar,
> > 
> > On Fri, Mar 29, 2024 at 05:00:26PM +0000, Easwar Hariharan wrote:
> >> I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave"
> > 
> > I don't understand why we forget that i3c is 1.1.1 :-)
> 
> That's because it's a copy-paste error from Wolfram's cover letter. :) I'll update
> next go-around.

not a binding comment, though. Just for completeness, because we
are giving the version to the i2c and smbus, but not i3c.

> >> with more appropriate terms. Inspired by and following on to Wolfram's
> >> series to fix drivers/i2c/[1], fix the terminology for users of
> >> I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists
> >> in the specification.
> > 
> > The specification talks about:
> > 
> >  - master -> controller
> >  - slave -> target (and not client)
> > 
> > But both you and Wolfram have used client. I'd like to reach
> > some more consistency here.
> 
> I had the impression that remote targets (i.e external to the device) were to be called clients,
> e.g. the QSFP FRUs in drivers/infiniband, and internal ones targets.
> I chose the terminology according to that understanding, but now I can't find where I got that
> information.

The word "client" does not even appear in the documentation (only
one instance in the i3c document), so that the change is not
related to the document as stated in the commit log. Unless, of
course, I am missing something.

I'm OK with choosing a "customized" naming, but we need to reach
an agreement.

I raised the same question to Wolfram.

Thanks,
Andi