linux-kernel - Re: [PATCH v1 1/1] platform/x86: quickstart: Miscellaneous improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 29 Mar 2024 19:43:24 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Armin Wolf <W_Armin@....de>
Cc: Andy Shevchenko <andy.shevchenko@...il.com>,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
	Hans de Goede <hdegoede@...hat.com>,
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Subject: Re: [PATCH v1 1/1] platform/x86: quickstart: Miscellaneous
 improvements

Fri, Mar 29, 2024 at 01:23:25AM +0100, Armin Wolf kirjoitti:
> Am 28.03.24 um 09:50 schrieb Andy Shevchenko:
> > On Thu, Mar 28, 2024 at 1:35 AM Armin Wolf <W_Armin@....de> wrote:
> > > Am 27.03.24 um 22:52 schrieb Andy Shevchenko:

..

> > > > -#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> > > that is the reason for removing this?
> > Yes, it's a dead code. Likely the cargo cult line was copied from
> > another driver.
> > 
> In that case: Reviewed-by: Armin Wolf <W_Armin@....de>

Thank you!

You need to use a whole line for the tag.

P.S.
It seems Hans hadn't folded anything from here, so I will send a patch
(series?) next week.


-- 
With Best Regards,
Andy Shevchenko