linux-kernel - Re: [PATCH 1/1] platform/x86/intel/hid: Don't wake on 5-button releases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bk6wlxpp.fsf@gmail.com>
Date: Fri, 29 Mar 2024 15:06:10 -0300
From: David McFarland <corngood@...il.com>
To: "Linux regression tracking (Thorsten Leemhuis)" <regressions@...mhuis.info>
Cc: Chris Feng <chris.feng@...iatek.com>,  Linux regressions mailing list
 <regressions@...ts.linux.dev>,  "Rafael J . Wysocki"
 <rafael.j.wysocki@...el.com>,  Alex Hung <alexhung@...il.com>,  Hans de
 Goede <hdegoede@...hat.com>,  Ilpo Järvinen
 <ilpo.jarvinen@...ux.intel.com>,  "platform-driver-x86@...r.kernel.org"
 <platform-driver-x86@...r.kernel.org>,  LKML
 <linux-kernel@...r.kernel.org>,  linux-pm@...r.kernel.org
Subject: Re: [PATCH 1/1] platform/x86/intel/hid: Don't wake on 5-button
 releases

"Linux regression tracking (Thorsten Leemhuis)"
<regressions@...mhuis.info> writes:

> David, from here is looks like this is stalled for ten days now. Or was
> there some progress and I just missed it?

No, I've not seen any emails since your last.

> From the cover letter[1] is sounds a lot like a "Fixes: 0c4cae1bc00d31
> ("PM: hibernate: Avoid missing wakeup events during hibernation")" would
> be appropriate here.

The specific behaviour I encountered (failure to hibernate) started with
that commit, but I think it just exposed the underlying behaviour (wake
on button release), which probably dates to when the driver was
introduced.

I believe it would have been possible to reproduce the other behaviour I
mentioned (long hold of button to suspend causes the machine to wake on
release), even before 0c4cae1bc00d31.

That's why I left it off, but I'm happy to revise.