lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 29 Mar 2024 11:44:01 -0700
From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.intel.com>
To: Maxim Korotkov <korotkov.maxim.s@...il.com>, Armin Wolf <W_Armin@....de>,
 Kenneth Chan <kenneth.t.chan@...il.com>
Cc: Len Brown <len.brown@...el.com>,
 Henrique de Moraes Holschuh <hmh@....eng.br>,
 Harald Welte <laforge@...monks.org>, Matthew Garrett <mjg@...hat.com>,
 Ivan Kapranov <i.kapranov@...uritycode.ru>, lvc-project@...uxtesting.org,
 platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86: panasonic-laptop: fix NULL dereference


On 3/29/24 1:20 AM, Maxim Korotkov wrote:
> Hi,
> On 29.03.2024 03:21, Armin Wolf wrote:
>>> Added a pointer check to ensure that it is valid
>>> before using it for pcc initialization.
>>
>> Hi,
>>
>> is this check even needed? I think the ACPI driver core takes care
>> of passing a valid ACPI device pointer to acpi_pcc_hotkey_remove().
>>
>> Thanks,
>> Armin Wolf
>
> I proceeded from the assumption that the current check was not redundant.
> Kuppuswamy correctly noted in the message that the device would most likely be valid for the function of removal.
>
> However, in my opinion, checking for NULL is a good coding practice, and has now been implemented incorrectly in this case.
>
> Eliminating NULL checks could potentially cause bugs in this context.

Usually such checks are added when dealing with input that can change dynamically (like user input).

Since, as per the current usage, there is no chance for this device to be NULL, I don't think we need it.

>
> Best regards, Max

-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ