linux-kernel - Re: [PATCH] selftests/mm: import strings.h for ffsl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <909806c1-a9c4-4f51-a807-46075efb8ab9@collabora.com>
Date: Sat, 30 Mar 2024 00:33:05 +0500
From: Muhammad Usama Anjum <usama.anjum@...labora.com>
To: Edward Liaw <edliaw@...gle.com>, linux-kernel@...r.kernel.org,
 Andrew Morton <akpm@...ux-foundation.org>, Shuah Khan <shuah@...nel.org>,
 Nathan Chancellor <nathan@...nel.org>,
 Nick Desaulniers <ndesaulniers@...gle.com>, Bill Wendling
 <morbo@...gle.com>, Justin Stitt <justinstitt@...gle.com>,
 Peter Xu <peterx@...hat.com>, David Hildenbrand <david@...hat.com>,
 "Mike Rapoport (IBM)" <rppt@...nel.org>,
 Axel Rasmussen <axelrasmussen@...gle.com>
Cc: Muhammad Usama Anjum <usama.anjum@...labora.com>,
 linux-kselftest@...r.kernel.org, kernel-team@...roid.com,
 linux-mm@...ck.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] selftests/mm: import strings.h for ffsl

On 3/29/24 10:42 PM, Edward Liaw wrote:
> Got a compilation error for ffsl after 91b80cc5b39f ("selftests: mm: fix
> map_hugetlb failure on 64K page size systems") imported vm_util.h.
> 
> Fixes: af605d26a8f2 ("selftests/mm: merge util.h into vm_util.h")
Why do you think this Fixes tag is needed? This refers to a patch which is
just moving code. It doesn't seem to have any thing related to strings.h.

Other than that, LGTM
Reviewed-by: Muhammad Usama Anjum <usama.anjum@...labora.com>

> Signed-off-by: Edward Liaw <edliaw@...gle.com>
> ---
>  tools/testing/selftests/mm/vm_util.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/mm/vm_util.h b/tools/testing/selftests/mm/vm_util.h
> index c02990bbd56f..9007c420d52c 100644
> --- a/tools/testing/selftests/mm/vm_util.h
> +++ b/tools/testing/selftests/mm/vm_util.h
> @@ -3,7 +3,7 @@
>  #include <stdbool.h>
>  #include <sys/mman.h>
>  #include <err.h>
> -#include <string.h> /* ffsl() */
> +#include <strings.h> /* ffsl() */
>  #include <unistd.h> /* _SC_PAGESIZE */
>  
>  #define BIT_ULL(nr)                   (1ULL << (nr))

-- 
BR,
Muhammad Usama Anjum