linux-kernel - Re: [PATCH 3/3] dt-bindings: adc: Document XuanTie TH1520 ADC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 29 Mar 2024 16:29:32 -0500
From: Rob Herring <robh@...nel.org>
To: wefu@...hat.com
Cc: nuno.sa@...log.com, okan.sahin@...log.com, palmer@...belt.com, 
 conor@...nel.org, mike.looijmans@...ic.nl, devicetree@...r.kernel.org, 
 jic23@...nel.org, marcelo.schmitt@...log.com, marius.cristea@...rochip.com, 
 guoren@...nel.org, andriy.shevchenko@...ux.intel.com, jszhang@...nel.org, 
 bigunclemax@...il.com, lee@...nel.org, linux-kernel@...r.kernel.org, 
 linux-riscv@...ts.infradead.org, krzysztof.kozlowski+dt@...aro.org, 
 linux-iio@...r.kernel.org, paul.walmsley@...ive.com, aou@...s.berkeley.edu, 
 marcus.folkesson@...il.com, lars@...afoo.de, fr0st61te@...il.com, 
 schnelle@...ux.ibm.com
Subject: Re: [PATCH 3/3] dt-bindings: adc: Document XuanTie TH1520 ADC

On Sat, 30 Mar 2024 04:01:26 +0800, wefu@...hat.com wrote:
> From: Wei Fu <wefu@...hat.com>
> 
> Document devicetree bindings for the XuanTie TH1520 AP sub-system ADC.
> 
> Signed-off-by: Wei Fu <wefu@...hat.com>
> ---
>  .../bindings/iio/adc/thead,th1520.yaml        | 52 +++++++++++++++++++
>  1 file changed, 52 insertions(+)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
/Documentation/devicetree/bindings/iio/adc/thead,th1520.yaml:45:1: [error] syntax error: found character '\t' that cannot start any token (syntax)

dtschema/dtc warnings/errors:
make[2]: *** Deleting file 'Documentation/devicetree/bindings/iio/adc/thead,th1520.example.dts'
Documentation/devicetree/bindings/iio/adc/thead,th1520.yaml:45:1: found a tab character where an indentation space is expected
make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/iio/adc/thead,th1520.example.dts] Error 1
make[2]: *** Waiting for unfinished jobs....
/Documentation/devicetree/bindings/iio/adc/thead,th1520.yaml:45:1: found a tab character where an indentation space is expected
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/thead,th1520.yaml: ignoring, error parsing file
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1430: dt_binding_check] Error 2
make: *** [Makefile:240: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240329200241.4122000-4-wefu@redhat.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.