lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAFGhKbz70E3vihRkG4Hi20Tw8i7mGp=Z6j+NnELDTJd9cj9+Aw@mail.gmail.com>
Date: Sat, 30 Mar 2024 00:08:02 +0100
From: Charlemagne Lasse <charlemagnelasse@...il.com>
To: Barry Song <21cnbao@...il.com>, Jonathan Corbet <corbet@....net>, workflows@...r.kernel.org, 
	linux-doc@...r.kernel.org, Andy Whitcroft <apw@...onical.com>, 
	Joe Perches <joe@...ches.com>, Dwaipayan Ray <dwaipayanray1@...il.com>, lukas.bulwahn@...il.com
Cc: LKML <linux-kernel@...r.kernel.org>, Xining Xu <ma.xxn@...look.com>, 
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v3 2/2] scripts: checkpatch: check unused parameters for
 function-like macro

Hi,

Can this patch please be dropped from Linux-next (currently via
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm#mm-everything)?
It is obviously wrong when dealing with named variadic macro
parameters:

 ./scripts/checkpatch.pl -f include/linux/rculist.h
ERROR: Parameter 'dummy' is not used in function-like macro, please
use static inline instead
#51: FILE: include/linux/rculist.h:51:
+#define __list_check_rcu(dummy, cond, extra...)
         \
+       ({                                                              \
+       check_arg_count_one(extra);                                     \
+       RCU_LOCKDEP_WARN(!(cond) && !rcu_read_lock_any_held(),          \
+                        "RCU-list traversed in non-reader section!");  \
+       })

ERROR: Parameter 'extra...' is not used in function-like macro, please
use static inline instead
#51: FILE: include/linux/rculist.h:51:
+#define __list_check_rcu(dummy, cond, extra...)
         \
+       ({                                                              \
+       check_arg_count_one(extra);                                     \
+       RCU_LOCKDEP_WARN(!(cond) && !rcu_read_lock_any_held(),          \
+                        "RCU-list traversed in non-reader section!");  \
+       })

ERROR: Parameter 'dummy' is not used in function-like macro, please
use static inline instead
#64: FILE: include/linux/rculist.h:64:
+#define __list_check_rcu(dummy, cond, extra...)
         \
+       ({ check_arg_count_one(extra); })

ERROR: Parameter 'cond' is not used in function-like macro, please use
static inline instead
#64: FILE: include/linux/rculist.h:64:
+#define __list_check_rcu(dummy, cond, extra...)
         \
+       ({ check_arg_count_one(extra); })

ERROR: Parameter 'extra...' is not used in function-like macro, please
use static inline instead
#64: FILE: include/linux/rculist.h:64:
+#define __list_check_rcu(dummy, cond, extra...)
         \
+       ({ check_arg_count_one(extra); })

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ