linux-kernel - Re: [PATCH 0/3] usb: typec: ucsi: Ack connector change early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 29 Mar 2024 07:56:03 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: "Christian A. Ehrhardt" <lk@...e.de>
Cc: linux-kernel@...r.kernel.org, Diogo Ivo <diogo.ivo@...nico.ulisboa.pt>, 
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Prashant Malani <pmalani@...omium.org>, 
	Jameson Thies <jthies@...gle.com>, Abhishek Pandit-Subedi <abhishekpandit@...omium.org>, 
	Neil Armstrong <neil.armstrong@...aro.org>, 
	Uwe Kleine-König <u.kleine-koenig@...gutronix.de>, 
	Samuel Čavoj <samuel@...oj.net>, linux-usb@...r.kernel.org
Subject: Re: [PATCH 0/3] usb: typec: ucsi: Ack connector change early

On Thu, 28 Mar 2024 at 00:46, Christian A. Ehrhardt <lk@...e.de> wrote:
>
> As briefly discussed here
>   https://lore.kernel.org/lkml/Zf1XUrG1UbVJWzoz@kuha.fi.intel.com/
> acknowledge connector change events along with the first command
> in ucsi_handle_connector_change(). The connector lock should be
> sufficient to protect the rest of the function and the partner
> tasks.
>
> This allows us to remove the Dell quirk in ucsi_acpi.c.
> Additionally, this reduces the number of commands that are sent
> with an un-acknowleged connector change event.
>
> Christian A. Ehrhardt (3):
>   usb: typec: ucsi: Stop abuse of bit definitions from ucsi.h
>   usb: typec: ucsi: Never send a lone connector change ack
>   usb: typec: ucsi_acpi: Remove Dell quirk
>
>  drivers/usb/typec/ucsi/ucsi.c         | 48 ++++++++++-------------
>  drivers/usb/typec/ucsi/ucsi.h         |  2 -
>  drivers/usb/typec/ucsi/ucsi_acpi.c    | 56 ++-------------------------
>  drivers/usb/typec/ucsi/ucsi_stm32g0.c |  1 +
>  4 files changed, 25 insertions(+), 82 deletions(-)

Tested-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org> #
SM8450-HDK, sc8180x-primus


-- 
With best wishes
Dmitry