linux-kernel - Re: [PATCH] misc: uacce - add the null check for the input pointer and its pointer members

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024032946-supernova-unstaffed-63ec@gregkh>
Date: Fri, 29 Mar 2024 07:34:50 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Chenghai Huang <huangchenghai2@...wei.com>
Cc: zhangfei.gao@...aro.org, wangzhou1@...ilicon.com,
	linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
	fanghao11@...wei.com, shenyang39@...wei.com, liulongfang@...wei.com,
	qianweili@...wei.com
Subject: Re: [PATCH] misc: uacce - add the null check for the input pointer
 and its pointer members

On Fri, Mar 29, 2024 at 02:26:55PM +0800, Chenghai Huang wrote:
> The uacce_alloc() is the member of the EXPORT_SYMBOL_GPL. Therefore, null
> pointer verification is added on the pointer type input parameter and its
> pointer members.

I do not understand, why does the export type matter?  Just fix any
callers to use this properly and send proper parameters.  What in-tree
caller needs this?

thanks,

greg k-h