linux-kernel - RE: Re: [net-next PATCH v3] octeontx2-pf: Reset MAC stats during probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date: Fri, 29 Mar 2024 09:06:33 +0000
From: Sai Krishna Gajula <saikrishnag@...vell.com>
To: "kuba@...nel.org" <kuba@...nel.org>,
        "davem@...emloft.net"
	<davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        Geethasowjanya Akula <gakula@...vell.com>,
        Hariprasad Kelam
	<hkelam@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>
Subject: RE: Re: [net-next PATCH v3] octeontx2-pf: Reset MAC stats during
 probe

 
 > -----Original Message-----
 > From: Jakub Kicinski <kuba@...nel.org>
 > Sent: Tuesday, March 12, 2024 3:44 AM
 > To: Sai Krishna Gajula <saikrishnag@...vell.com>
 > Cc: davem@...emloft.net; edumazet@...gle.com; pabeni@...hat.com;
 > netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Sunil Kovvuri
 > Goutham <sgoutham@...vell.com>; Geethasowjanya Akula
 > <gakula@...vell.com>; Hariprasad Kelam <hkelam@...vell.com>;
 Subbaraya
 > Sundeep Bhatta <sbhatta@...vell.com>
 > Subject: Re: [net-next PATCH v3] octeontx2-pf: Reset MAC
 > stats during probe
 >
  > On Fri, 8 Mar 2024 23:45:44 +0530 Sai Krishna wrote:
 > > @@ -3048,6 +3065,9 @@ static int otx2_probe(struct pci_dev *pdev,
 > > const struct pci_device_id *id)
 > >
 > >  	otx2_qos_init(pf, qos_txqs);
 > >
 > > +	/* reset CGX/RPM MAC stats */
 > > +	otx2_reset_mac_stats(pf);
 > > +
 > >  	return 0;
 >
 > Looks suspicious, all sort of resets should be usually done before the
 > netdev / devlink instances are registered. As soon as you register
 > those they may get brought up and used (including synchronously by an in-
 kernel user).

Agreed to your point, will send V4 patch with the suggested change. Apologies for delayed acknowledgement, as I overlooked the review mail.

 > --
 > pw-bot: cr