linux-kernel - Re: [PATCH] scripts/unifdef: avoid constexpr keyword

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 29 Mar 2024 18:59:26 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Tony Finch <dot@...at.at>, Sam Ravnborg <sam@...nborg.org>, Arnd Bergmann <arnd@...db.de>, 
	Nathan Chancellor <nathan@...nel.org>, Nicolas Schier <nicolas@...sle.eu>, linux-kbuild@...r.kernel.org, 
	Michal Marek <mmarek@...e.cz>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scripts/unifdef: avoid constexpr keyword

On Thu, Mar 21, 2024 at 3:01 AM Arnd Bergmann <arnd@...nel.org> wrote:
>
> From: Arnd Bergmann <arnd@...db.de>
>
> Starting with c23, 'constexpr' is a keyword in C like in C++ and cannot
> be used as an identifier:
>
> scripts/unifdef.c:206:25: error: 'constexpr' can only be used in variable declarations
>   206 | static bool             constexpr;              /* constant #if expression */
>       |                         ^
> scripts/unifdef.c:880:13: error: expected identifier or '('
>   880 |                 constexpr = false;
>       |                           ^
>
> Rename this instance to allow changing to C23 at some point in the future.
>
> Fixes: d8379ab1dde3 ("unifdef: update to upstream revision 1.190")

This can be a problem only for future kernels.
Is it worth adding Fixes?

Even if the kernel bumps to C23 at some point,
such a patch will not be backported.




-- 
Best Regards
Masahiro Yamada