linux-kernel - Re: [PATCH v5 4/5] clk: qcom: ipq9574: Use icc-clk for enabling NoC related clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 29 Mar 2024 13:10:03 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Varadarajan Narayanan <quic_varada@...cinc.com>,
 Stephen Boyd <sboyd@...nel.org>
Cc: andersson@...nel.org, conor+dt@...nel.org, devicetree@...r.kernel.org,
 djakov@...nel.org, dmitry.baryshkov@...aro.org, konrad.dybcio@...aro.org,
 krzysztof.kozlowski+dt@...aro.org, linux-arm-msm@...r.kernel.org,
 linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-pm@...r.kernel.org, mturquette@...libre.com, quic_anusha@...cinc.com,
 robh@...nel.org
Subject: Re: [PATCH v5 4/5] clk: qcom: ipq9574: Use icc-clk for enabling NoC
 related clocks

On 29/03/2024 11:55, Varadarajan Narayanan wrote:
>>> +
>>> +enum {
>>> +       ICC_ANOC_PCIE0,
>>> +       ICC_SNOC_PCIE0,
>>> +       ICC_ANOC_PCIE1,
>>> +       ICC_SNOC_PCIE1,
>>> +       ICC_ANOC_PCIE2,
>>> +       ICC_SNOC_PCIE2,
>>> +       ICC_ANOC_PCIE3,
>>> +       ICC_SNOC_PCIE3,
>>> +       ICC_SNOC_USB,
>>> +       ICC_ANOC_USB_AXI,
>>> +       ICC_NSSNOC_NSSCC,
>>> +       ICC_NSSNOC_SNOC_0,
>>> +       ICC_NSSNOC_SNOC_1,
>>> +       ICC_NSSNOC_PCNOC_1,
>>> +       ICC_NSSNOC_QOSGEN_REF,
>>> +       ICC_NSSNOC_TIMEOUT_REF,
>>> +       ICC_NSSNOC_XO_DCD,
>>> +       ICC_NSSNOC_ATB,
>>> +       ICC_MEM_NOC_NSSNOC,
>>> +       ICC_NSSNOC_MEMNOC,
>>> +       ICC_NSSNOC_MEM_NOC_1,
>>> +};
>>
>> Are these supposed to be in a dt-binding header?
> 
> Since these don't directly relate to the ids in the dt-bindings
> not sure if they will be permitted there. Will move and post a
> new version and get feedback.

You can answer this by yourself by looking at your DTS. Do you use them
as well in the DTS?

It's a pity we see here only parts of DTS, instead of full interconnect
usage.

Best regards,
Krzysztof