linux-kernel - Re: [PATCH] mm: init_mlocked_on_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 29 Mar 2024 12:26:46 +0000
From: Matthew Wilcox <willy@...radead.org>
To: York Jasper Niebuhr <yjnworkstation@...il.com>
Cc: akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	willy@...ux.intel.com, linux-mm@...ck.org
Subject: Re: [PATCH] mm: init_mlocked_on_free_v3

On Fri, Mar 29, 2024 at 12:54:46PM +0100, York Jasper Niebuhr wrote:
> +	if (want_init_mlocked_on_free() && folio_test_mlocked(folio)
> +		&& !delay_rmap && folio_test_anon(folio)) {
> +		kernel_init_pages(page, 1);

Confusing indentation.  One of these two options:

	if (want_init_mlocked_on_free() && folio_test_mlocked(folio) &&
	    !delay_rmap && folio_test_anon(folio)) {
		kernel_init_pages(page, 1);

	if (want_init_mlocked_on_free() && folio_test_mlocked(folio) &&
			!delay_rmap && folio_test_anon(folio)) {
		kernel_init_pages(page, 1);

Also, '1' is incorrect.  Should be folio_nr_pages(folio).

> @@ -2559,12 +2570,21 @@ static void __init mem_debugging_and_hardening_init(void)
>  	}
>  #endif
>  
> -	if ((_init_on_alloc_enabled_early || _init_on_free_enabled_early) &&
> +	if ((_init_on_alloc_enabled_early || _init_on_free_enabled_early
> +		|| _init_mlocked_on_free_enabled_early) &&
>  	    page_poisoning_requested) {

Wrong indentation again.  I'm not going to point these out every time,
just fix it throughout.