linux-kernel - Re: [PATCH 10/10] sparc64: Fix prototype warnings for vdso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <5e956d59-65f5-405c-8fc1-8faf68f1f02d@app.fastmail.com>
Date: Sat, 30 Mar 2024 11:16:02 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Sam Ravnborg" <sam@...nborg.org>,
 "Andreas Larsson" <andreas@...sler.com>,
 "David S . Miller" <davem@...emloft.net>, sparclinux@...r.kernel.org
Cc: "Nick Bowler" <nbowler@...conx.ca>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 10/10] sparc64: Fix prototype warnings for vdso

On Sat, Mar 30, 2024, at 10:57, Sam Ravnborg via B4 Relay wrote:
> From: Sam Ravnborg <sam@...nborg.org>
>
> Fix the following warnings:
> arch/sparc/vdso/vclock_gettime.c:254:1: error: no previous prototype 
> for ‘__vdso_clock_gettime’
> arch/sparc/vdso/vclock_gettime.c:282:1: error: no previous prototype 
> for ‘__vdso_clock_gettime_stick’
> arch/sparc/vdso/vclock_gettime.c:307:1: error: no previous prototype 
> for ‘__vdso_gettimeofday’
> arch/sparc/vdso/vclock_gettime.c:343:1: error: no previous prototype 
> for ‘__vdso_gettimeofday_stick’
> arch/sparc/vdso/vdso32/../vclock_gettime.c:254:1: error: no previous 
> prototype for ‘__vdso_clock_gettime’
> arch/sparc/vdso/vdso32/../vclock_gettime.c:282:1: error: no previous 
> prototype for ‘__vdso_clock_gettime_stick’
> arch/sparc/vdso/vdso32/../vclock_gettime.c:307:1: error: no previous 
> prototype for ‘__vdso_gettimeofday’
> arch/sparc/vdso/vdso32/../vclock_gettime.c:343:1: error: no previous 
> prototype for ‘__vdso_gettimeofday_stick’
>
> The warnings were fixed by adding the proper prototypes to asm/vdso.h.
> The better fix would be to convert sparc to be y2038 compliant so the
> generic variant of vdso.h could be used.

I would prefer leaving the warning here until it is fixed
properly, or possibly removing the broken compat vdso
support. The other patches look fine though.

      Arnd