linux-kernel - Re: [PATCH AUTOSEL 6.8 69/98] sparc: vdso: Disable UBSAN instrumentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202403291904.05D45FDD2@keescook>
Date: Fri, 29 Mar 2024 19:05:37 -0700
From: Kees Cook <keescook@...omium.org>
To: Sasha Levin <sashal@...nel.org>
Cc: linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	Sam Ravnborg <sam@...nborg.org>, davem@...emloft.net,
	andreas@...sler.com, masahiroy@...nel.org, nicolas@...sle.eu,
	guoren@...nel.org, rmk+kernel@...linux.org.uk,
	sparclinux@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 6.8 69/98] sparc: vdso: Disable UBSAN
 instrumentation

On Fri, Mar 29, 2024 at 08:37:40AM -0400, Sasha Levin wrote:
> From: Kees Cook <keescook@...omium.org>
> 
> [ Upstream commit d4be85d068b4418c341f79b654399f7f0891069a ]
> 
> The UBSAN instrumentation cannot work in the vDSO since it is executing
> in userspace, so disable it in the Makefile. Fixes the build failures
> such as:
> 
> arch/sparc/vdso/vclock_gettime.c:217: undefined reference to `__ubsan_handle_shift_out_of_bounds'
> 
> Acked-by: Sam Ravnborg <sam@...nborg.org>
> Link: https://lore.kernel.org/all/20240224073617.GA2959352@ravnborg.org
> Signed-off-by: Kees Cook <keescook@...omium.org>
> Signed-off-by: Sasha Levin <sashal@...nel.org>

This is harmless to backport, but doesn't do anything. (The UBSAN
changes needing this are only in Linus's tree.)

-Kees

-- 
Kees Cook