linux-kernel - Re: [PATCH RFC 1/7] regulator: devres: add APIs for reference supplies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240330160246.6b74bd3b@jic23-huawei>
Date: Sat, 30 Mar 2024 16:02:46 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Mark Brown <broonie@...nel.org>
Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>, David Lechner
 <dlechner@...libre.com>, Jonathan Corbet <corbet@....net>, Liam Girdwood
 <lgirdwood@...il.com>, Jean Delvare <jdelvare@...e.com>, Guenter Roeck
 <linux@...ck-us.net>, Support Opensource <support.opensource@...semi.com>,
 Cosmin Tanislav <cosmin.tanislav@...log.com>, Lars-Peter Clausen
 <lars@...afoo.de>, Michael Hennerich <Michael.Hennerich@...log.com>,
 Antoniu Miclaus <antoniu.miclaus@...log.com>, Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-hwmon@...r.kernel.org,
 linux-iio@...r.kernel.org, linux-staging@...ts.linux.dev,
 linux-input@...r.kernel.org
Subject: Re: [PATCH RFC 1/7] regulator: devres: add APIs for reference
 supplies

On Thu, 28 Mar 2024 20:25:31 +0000
Mark Brown <broonie@...nel.org> wrote:

> On Thu, Mar 28, 2024 at 01:17:52PM -0700, Dmitry Torokhov wrote:
> > On Thu, Mar 28, 2024 at 06:18:32PM +0000, Mark Brown wrote:  
> 
> > > I don't follow what you're saying here?  What normal APIs are not
> > > available?  AFAICT this has nothing to do with a devm enable, it's a
> > > combined operation which reports the voltage for the regulator if one is
> > > available which would still be being added even if it used a devm
> > > enable.  
> 
> > You can not do devm_regulator_get_enable() and then call
> > regulator_get_voltage(), you need a new combined API.  
> 
> I think the theory here is that there are so many instances of this
> reference voltage pattern that it's useful to have a helper for that
> reason alone.

Exactly that - this is just adding a convenience function to
remove boilerplate.  -20ish lines of cut and paste code per
driver. 

Jonathan