linux-kernel - Re: [PATCH 1/2] wifi: mac80211: remove ieee80211_set_hw_80211

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1c69304c-abaf-46e4-b58d-a4f9b30a8f5f@infradead.org>
Date: Sat, 30 Mar 2024 09:20:45 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Jeff Johnson <quic_jjohnson@...cinc.com>,
 Johannes Berg <johannes@...solutions.net>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] wifi: mac80211: remove ieee80211_set_hw_80211_encap()



On 3/29/24 13:27, Jeff Johnson wrote:
> While fixing kernel-doc issues it was discovered that the
> ieee80211_set_hw_80211_encap() prototype doesn't actually have an
> implementation, so remove it.
> 
> Note the implementation was rmeoved in patch 6aea26ce5a4c ("mac80211:
> rework tx encapsulation offload API").
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>

Reviewed-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
>  include/net/mac80211.h | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/include/net/mac80211.h b/include/net/mac80211.h
> index 353488ab94a2..e6a11a982ca8 100644
> --- a/include/net/mac80211.h
> +++ b/include/net/mac80211.h
> @@ -7478,18 +7478,6 @@ u32 ieee80211_calc_rx_airtime(struct ieee80211_hw *hw,
>  u32 ieee80211_calc_tx_airtime(struct ieee80211_hw *hw,
>  			      struct ieee80211_tx_info *info,
>  			      int len);
> -/**
> - * ieee80211_set_hw_80211_encap - enable hardware encapsulation offloading.
> - *
> - * This function is used to notify mac80211 that a vif can be passed raw 802.3
> - * frames. The driver needs to then handle the 802.11 encapsulation inside the
> - * hardware or firmware.
> - *
> - * @vif: &struct ieee80211_vif pointer from the add_interface callback.
> - * @enable: indicate if the feature should be turned on or off
> - */
> -bool ieee80211_set_hw_80211_encap(struct ieee80211_vif *vif, bool enable);
> -
>  /**
>   * ieee80211_get_fils_discovery_tmpl - Get FILS discovery template.
>   * @hw: pointer obtained from ieee80211_alloc_hw().
> 

-- 
#Randy