linux-kernel - RE: [PATCH v5 4/4] clk: imx: add i.MX95 BLK CTL clk driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 31 Mar 2024 12:01:44 +0000
From: Peng Fan <peng.fan@....com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, "Peng Fan (OSS)"
	<peng.fan@....nxp.com>, Michael Turquette <mturquette@...libre.com>, Stephen
 Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>,
	Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>, Fabio Estevam
	<festevam@...il.com>, Abel Vesa <abelvesa@...nel.org>
CC: "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v5 4/4] clk: imx: add i.MX95 BLK CTL clk driver

> Subject: Re: [PATCH v5 4/4] clk: imx: add i.MX95 BLK CTL clk driver
> 
> On 24/03/2024 08:52, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@....com>
> >
> 
> ...
> 
> > +
> > +static const struct of_device_id imx95_bc_of_match[] = {
> > +	{ .compatible = "nxp,imx95-camera-csr", .data = &camblk_dev_data },
> > +	{ .compatible = "nxp,imx95-display-master-csr", },
> > +	{ .compatible = "nxp,imx95-lvds-csr", .data = &lvds_csr_dev_data },
> > +	{ .compatible = "nxp,imx95-display-csr", .data =
> &dispmix_csr_dev_data },
> > +	{ .compatible = "nxp,imx95-vpu-csr", .data = &vpublk_dev_data },
> > +	{ /* Sentinel */ },
> > +};
> > +MODULE_DEVICE_TABLE(of, imx95_bc_of_match);
> > +
> > +static struct platform_driver imx95_bc_driver = {
> > +	.probe = imx95_bc_probe,
> > +	.driver = {
> > +		.name = "imx95-blk-ctl",
> > +		.of_match_table = of_match_ptr(imx95_bc_of_match),
> 
> Drop of_match_ptr(), causes warnings. From where did you copy such code?
> Which mainline driver has such pattern?

I recall that when COMPILE_TEST is selected, OF is not selected, kernel
robot reports warning. This may not be true now.

I could drop it in v6.

Thanks,
Peng.

> 
> Best regards,
> Krzysztof