linux-kernel - RE: [EXTERNAL] Re: [PATCH v7 4/4] ASoc: dt-bindings: PCM6240: Add initial DT binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <41797fe7d5bb41b4bdea4ee7f4957291@ti.com>
Date: Sun, 31 Mar 2024 13:20:38 +0000
From: "Ding, Shenghao" <shenghao-ding@...com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC: "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "broonie@...nel.org"
	<broonie@...nel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>,
        "conor+dt@...nel.org" <conor+dt@...nel.org>,
        "linux-sound@...r.kernel.org"
	<linux-sound@...r.kernel.org>,
        "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>,
        "perex@...ex.cz" <perex@...ex.cz>, "tiwai@...e.com" <tiwai@...e.com>,
        "13916275206@....com"
	<13916275206@....com>,
        "Chawla, Mohit" <mohit.chawla@...com>, "soyer@....hu"
	<soyer@....hu>,
        "Huang, Jonathan" <jkhuang3@...com>, "tiwai@...e.de"
	<tiwai@...e.de>,
        "Djuandi, Peter" <pdjuandi@...com>,
        "Agrawal, Manisha"
	<manisha.agrawal@...com>,
        "Hari, Raj" <s-hari@...com>, "Yashar, Avi"
	<aviel@...com>,
        "Nagalla, Hari" <hnagalla@...com>,
        "Bajjuri, Praneeth"
	<praneeth@...com>,
        "Baojun.Xu@....com" <Baojun.Xu@....com>,
        Rob Herring
	<robh@...nel.org>
Subject: RE: [EXTERNAL] Re: [PATCH v7 4/4] ASoc: dt-bindings: PCM6240: Add
 initial DT binding

Hi Krzysztof
Answer inline
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Sunday, March 31, 2024 4:15 PM
> To: Ding, Shenghao <shenghao-ding@...com>; linux-kernel@...r.kernel.org
> Cc: lgirdwood@...il.com; broonie@...nel.org; robh+dt@...nel.org;
> krzysztof.kozlowski+dt@...aro.org; conor+dt@...nel.org; linux-
> sound@...r.kernel.org; devicetree@...r.kernel.org; perex@...ex.cz;
> tiwai@...e.com; 13916275206@....com; Chawla, Mohit
> <mohit.chawla@...com>; soyer@....hu; Huang, Jonathan
> <jkhuang3@...com>; tiwai@...e.de; Djuandi, Peter <pdjuandi@...com>;
> Agrawal, Manisha <manisha.agrawal@...com>; Hari, Raj <s-hari@...com>;
> Yashar, Avi <aviel@...com>; Nagalla, Hari <hnagalla@...com>; Bajjuri,
> Praneeth <praneeth@...com>; Baojun.Xu@....com; Rob Herring
> <robh@...nel.org>
> Subject: [EXTERNAL] Re: [PATCH v7 4/4] ASoc: dt-bindings: PCM6240: Add
> initial DT binding
> 
.............................
> >  - remove unneeded items and if branches.
> >  - Add missing compatible devices, such as adc6120, etc.
> >  - Add necessary people into the list for DTS review
> >  - correct misaligned.
> >  - simplify the compatibility
> >  - remove sound-name-prefix and revert back
> >  - Add review information
> 
> All these changes in v7 and you still kept Rob's review? I think either review
> was not given or your changelog is just incorrect.
Since Rob's review, nothing changed in yaml. Even in this patch, only removed kcontrol interfaces
in the code and added the mixer-test report in cover-letter as Mark suggested, which is no effect
on yaml file.
> 
> 
> 
> Best regards,
> Krzysztof