linux-kernel - Re: [PATCH v4 2/2] scripts: checkpatch: check unused parameters for function-like macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dbe8ea1a6a3b599a00eeb8ba0254fde785a500b9.camel@perches.com>
Date: Sun, 31 Mar 2024 08:54:00 -0700
From: Joe Perches <joe@...ches.com>
To: Mac Xu <mac.xxn@...look.com>, Barry Song <21cnbao@...il.com>, 
	"akpm@...ux-foundation.org"
	 <akpm@...ux-foundation.org>, "linux-doc@...r.kernel.org"
	 <linux-doc@...r.kernel.org>
Cc: "apw@...onical.com" <apw@...onical.com>, "broonie@...nel.org"
 <broonie@...nel.org>, "chenhuacai@...ngson.cn" <chenhuacai@...ngson.cn>, 
 "chris@...kel.net" <chris@...kel.net>, "corbet@....net" <corbet@....net>, 
 "dwaipayanray1@...il.com" <dwaipayanray1@...il.com>,
 "herbert@...dor.apana.org.au" <herbert@...dor.apana.org.au>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux@...ck-us.net" <linux@...ck-us.net>,  "lukas.bulwahn@...il.com"
 <lukas.bulwahn@...il.com>, "sfr@...b.auug.org.au" <sfr@...b.auug.org.au>, 
 "v-songbaohua@...o.com" <v-songbaohua@...o.com>,
 "workflows@...r.kernel.org" <workflows@...r.kernel.org>,  Max Filippov
 <jcmvbkbc@...il.com>
Subject: Re: [PATCH v4 2/2] scripts: checkpatch: check unused parameters for
 function-like macro

On Sun, 2024-03-31 at 13:46 +0000, Mac Xu wrote:
> > On Thu, 2024-03-28 at 15:21 +1300, Barry Song wrote:
> > > From: Xining Xu <mac.xxn@...look.com>
> > > 
> > > If function-like macros do not utilize a parameter, it might result in a
> > > build warning.  In our coding style guidelines, we advocate for utilizing
> > > static inline functions to replace such macros.  This patch verifies
> > > compliance with the new rule.
> > []
> > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> 
[]
> > It seems this logic is a bit redundant to existing
> > code and might be better added in the block that starts
> > 
> > (line 6026)
> > # check if any macro arguments are reused (ignore '...' and 'type')
> > 
> > as that already does each param in a #define and
> > ignores ... and type
> 
> Hi Joe,
> 
> Thank you for your comments with insights, as you said, code block of line 6026 is a better place to 
> place this new logic, as it already handles the logic I'd wanted like extracting, splitting and trimming 
> the arguments, excluding the trailing comments etc.
> 
> By placing the logic in the new place, code duplicates are reduced.
> 
> Here's my new code (inserted from line 6044):
> +# check if this is an unused argument
> +        if ($define_stmt !~ /\b$arg\b/) {
> +                WARN("UNUSED_ARG_IN_MACRO",

Perhaps
					WARN("MACRO_ARG_UNUSED",
			...

to better match the others above it in the block:

					CHK("MACRO_ARG_REUSE",
and
					CHK("MACRO_ARG_PRECEDENCE",

Other than that trivial bit, seems ok.