| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20240329150116.67da2b07@kernel.org> Date: Fri, 29 Mar 2024 15:01:16 -0700 From: Jakub Kicinski <kuba@...nel.org> To: Chintan Vankar <c-vankar@...com> Cc: Dan Carpenter <dan.carpenter@...aro.org>, Siddharth Vadapalli <s-vadapalli@...com>, Grygorii Strashko <grygorii.strashko@...com>, "Heiner Kallweit" <hkallweit1@...il.com>, Vladimir Oltean <vladimir.oltean@....com>, Andrew Lunn <andrew@...n.ch>, Roger Quadros <rogerq@...nel.org>, Richard Cochran <richardcochran@...il.com>, Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>, "David S. Miller" <davem@...emloft.net>, <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org> Subject: Re: [PATCH net-next v4 1/3] net: ethernet: ti: am65-cpts: Enable PTP RX HW timestamp using CPTS FIFO On Wed, 27 Mar 2024 11:12:32 +0530 Chintan Vankar wrote: > CPTS module supports capturing timestamp for every packet it receives, > add a new function named "am65_cpts_find_rx_ts()" to get the timestamp > of received packets from CPTS FIFO. > > Add another function named "am65_cpts_rx_timestamp()" which internally > calls "am65_cpts_find_rx_ts()" function and timestamps the received > PTP packets. Maybe i'm unusually tied today but reading this patch without reading the next one makes no sense. I mean, you say: CPTS module supports capturing timestamp for every packet it receives... How is that relevant here. When you post v5 please make sure to include a cover letter, explaining the overall goal and impact of the series. > + list_del_init(&event->list); > + list_add(&event->list, &cpts->pool); list_move() ? -- pw-bot: cr X-sender: <linux-kernel+bounces-125472-steffen.klassert=secunet.com@...r.kernel.org> X-Receiver: <steffen.klassert@...unet.com> ORCPT=rfc822;steffen.klassert@...unet.com NOTIFY=NEVER; X-ExtendedProps=BQAVABYAAgAAAAUAFAARAPDFCS25BAlDktII2g02frgPADUAAABNaWNyb3NvZnQuRXhjaGFuZ2UuVHJhbnNwb3J0LkRpcmVjdG9yeURhdGEuSXNSZXNvdXJjZQIAAAUAagAJAAEAAAAAAAAABQAWAAIAAAUAQwACAAAFAEYABwADAAAABQBHAAIAAAUAEgAPAGIAAAAvbz1zZWN1bmV0L291PUV4Y2hhbmdlIEFkbWluaXN0cmF0aXZlIEdyb3VwIChGWURJQk9IRjIzU1BETFQpL2NuPVJlY2lwaWVudHMvY249U3RlZmZlbiBLbGFzc2VydDY4YwUACwAXAL4AAACheZxkHSGBRqAcAp3ukbifQ049REI2LENOPURhdGFiYXNlcyxDTj1FeGNoYW5nZSBBZG1pbmlzdHJhdGl2ZSBHcm91cCAoRllESUJPSEYyM1NQRExUKSxDTj1BZG1pbmlzdHJhdGl2ZSBHcm91cHMsQ049c2VjdW5ldCxDTj1NaWNyb3NvZnQgRXhjaGFuZ2UsQ049U2VydmljZXMsQ049Q29uZmlndXJhdGlvbixEQz1zZWN1bmV0LERDPWRlBQAOABEABiAS9uuMOkqzwmEZDvWNNQUAHQAPAAwAAABtYngtZXNzZW4tMDIFADwAAgAADwA2AAAATWljcm9zb2Z0LkV4Y2hhbmdlLlRyYW5zcG9ydC5NYWlsUmVjaXBpZW50LkRpc3BsYXlOYW1lDwARAAAAS2xhc3NlcnQsIFN0ZWZmZW4FAAwAAgAABQBsAAIAAAUAWAAXAEoAAADwxQktuQQJQ5LSCNoNNn64Q049S2xhc3NlcnQgU3RlZmZlbixPVT1Vc2VycyxPVT1NaWdyYXRpb24sREM9c2VjdW5ldCxEQz1kZQUAJgACAAEFACIADwAxAAAAQXV0b1Jlc3BvbnNlU3VwcHJlc3M6IDANClRyYW5zbWl0SGlzdG9yeTogRmFsc2UNCg8ALwAAAE1pY3Jvc29mdC5FeGNoYW5nZS5UcmFuc3BvcnQuRXhwYW5zaW9uR3JvdXBUeXBlDwAVAAAATWVtYmVyc0dyb3VwRXhwYW5zaW9uBQAjAAIAAQ== X-CreatedBy: MSExchange15 X-HeloDomain: b.mx.secunet.com X-ExtendedProps: BQBjAAoAq5Lp8x1Q3AgFAGEACAABAAAABQA3AAIAAA8APAAAAE1pY3Jvc29mdC5FeGNoYW5nZS5UcmFuc3BvcnQuTWFpbFJlY2lwaWVudC5Pcmdhbml6YXRpb25TY29wZREAAAAAAAAAAAAAAAAAAAAAAAUASQACAAEFAGIACgALAAAAjIoAAAUABAAUIAEAAAAcAAAAc3RlZmZlbi5rbGFzc2VydEBzZWN1bmV0LmNvbQUABgACAAEFACkAAgABDwAJAAAAQ0lBdWRpdGVkAgABBQACAAcAAQAAAAUAAwAHAAAAAAAFAAUAAgABBQBkAA8AAwAAAEh1Yg== X-Source: SMTP:Default MBX-DRESDEN-01 X-SourceIPAddress: 62.96.220.37 X-EndOfInjectedXHeaders: 10845 Received: from cas-essen-02.secunet.de (10.53.40.202) by mbx-dresden-01.secunet.de (10.53.40.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.37; Fri, 29 Mar 2024 23:01:54 +0100 Received: from b.mx.secunet.com (62.96.220.37) by cas-essen-02.secunet.de (10.53.40.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 29 Mar 2024 23:01:54 +0100 Received: from localhost (localhost [127.0.0.1]) by b.mx.secunet.com (Postfix) with ESMTP id 43FD620270 for <steffen.klassert@...unet.com>; Fri, 29 Mar 2024 23:01:54 +0100 (CET) X-Virus-Scanned: by secunet X-Spam-Flag: NO X-Spam-Score: -3.099 X-Spam-Level: X-Spam-Status: No, score=-3.099 tagged_above=-999 required=2.1 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.099, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=unavailable autolearn_force=no Authentication-Results: a.mx.secunet.com (amavisd-new); dkim=pass (2048-bit key) header.d=kernel.org Received: from b.mx.secunet.com ([127.0.0.1]) by localhost (a.mx.secunet.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rUKtVu_udyEK for <steffen.klassert@...unet.com>; Fri, 29 Mar 2024 23:01:53 +0100 (CET) Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=147.75.80.249; helo=am.mirrors.kernel.org; envelope-from=linux-kernel+bounces-125472-steffen.klassert=secunet.com@...r.kernel.org; receiver=steffen.klassert@...unet.com DKIM-Filter: OpenDKIM Filter v2.11.0 b.mx.secunet.com BE1E4200BB Authentication-Results: b.mx.secunet.com; dkim=pass (2048-bit key) header.d=kernel.org header.i=@...nel.org header.b="HCDVp1+6" Received: from am.mirrors.kernel.org (am.mirrors.kernel.org [147.75.80.249]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by b.mx.secunet.com (Postfix) with ESMTPS id BE1E4200BB for <steffen.klassert@...unet.com>; Fri, 29 Mar 2024 23:01:53 +0100 (CET) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 8338A1F22B6F for <steffen.klassert@...unet.com>; Fri, 29 Mar 2024 22:01:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A474313DDAE; Fri, 29 Mar 2024 22:01:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@...nel.org header.b="HCDVp1+6" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EFDD13CF9A; Fri, 29 Mar 2024 22:01:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711749678; cv=none; b=TOauJdfJGKU0duUd8J4pHoHhAwsXcDn6HiMRRbIxMC8w4F8N/R6CuN8UW0dSXad7zTr71uirgCxvjz3p8yWCCy8Lua4blaGweObu3zF4POrf+k9u15OLletc265FFN5y6QWVgkTghnrO2lA7BPEgSHApf/YoTu1URgNAYZ6V86c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711749678; c=relaxed/simple; bh=nq/FsIJaEug5d9vw9MG+IgQd5liVDY8TkXYaFDuOCdo=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Y0voKxc3wu4aN9dqdlqCvCcRErWY477ia2U3s+zapOl4w1ETHJYUStVobjEYNexg0unHlP7Tb6mRFUmIC7L9k9Abt8vOwswUXlovEv/RYRNqCZh58Etm9FyIYE6rOXh15uvgsy9g+fHu21flV2ooGENu10WR0Qfm9Eo1N8RV3k8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@...nel.org header.b=HCDVp1+6; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53666C433C7; Fri, 29 Mar 2024 22:01:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711749677; bh=nq/FsIJaEug5d9vw9MG+IgQd5liVDY8TkXYaFDuOCdo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HCDVp1+6GYWN8GFmGWMO5xXfiuZa6bY/GlLwKiqaSa1TLzIxcYJihxRE0e5VLztHR 5zX4huDJPpeCfgrjlALPODEyY9ok6t6XZyC94u9P4uGbsdD+Vf7/goAP4qAxHkI24l Vp+Ec9ugCQi0u85nWx6u6+59B7MSXHvK7H7/fZ+H3lv3tvBPDnMR4RgmsEhvVyxon1 xplQn51eQjcegvhK7Sath6j4gOuf2pbrolfo17ILhabO8CfloJKPB+aXedyLdVRpG7 sAjIkjQeyiL63kut8QYGl9CThsDY1mDSdXu6r8nXPwWsINSIlXd0gVG41OCygsqiwZ FdtrYL4sDV2IA== Date: Fri, 29 Mar 2024 15:01:16 -0700 From: Jakub Kicinski <kuba@...nel.org> To: Chintan Vankar <c-vankar@...com> Cc: Dan Carpenter <dan.carpenter@...aro.org>, Siddharth Vadapalli <s-vadapalli@...com>, Grygorii Strashko <grygorii.strashko@...com>, "Heiner Kallweit" <hkallweit1@...il.com>, Vladimir Oltean <vladimir.oltean@....com>, Andrew Lunn <andrew@...n.ch>, Roger Quadros <rogerq@...nel.org>, Richard Cochran <richardcochran@...il.com>, Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>, "David S. Miller" <davem@...emloft.net>, <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org> Subject: Re: [PATCH net-next v4 1/3] net: ethernet: ti: am65-cpts: Enable PTP RX HW timestamp using CPTS FIFO Message-ID: <20240329150116.67da2b07@...nel.org> In-Reply-To: <20240327054234.1906957-1-c-vankar@...com> References: <20240327054234.1906957-1-c-vankar@...com> Precedence: bulk X-Mailing-List: linux-kernel@...r.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@...r.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@...r.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-Path: linux-kernel+bounces-125472-steffen.klassert=secunet.com@...r.kernel.org X-MS-Exchange-Organization-OriginalArrivalTime: 29 Mar 2024 22:01:54.3136 (UTC) X-MS-Exchange-Organization-Network-Message-Id: f786ccae-300d-498c-b6e0-08dc503bd85e X-MS-Exchange-Organization-OriginalClientIPAddress: 62.96.220.37 X-MS-Exchange-Organization-OriginalServerIPAddress: 10.53.40.202 X-MS-Exchange-Organization-Cross-Premises-Headers-Processed: cas-essen-02.secunet.de X-MS-Exchange-Organization-OrderedPrecisionLatencyInProgress: LSRV=mbx-dresden-01.secunet.de:TOTAL-HUB=0.406|SMR=0.337(SMRDE=0.035|SMRC=0.302(SMRCL=0.100|X-SMRCR=0.302))|CAT=0.067(CATOS=0.011 (CATSM=0.011(CATSM-Malware Agent=0.011))|CATRESL=0.039(CATRESLP2R=0.017)|CATORES=0.014 (CATRS=0.014(CATRS-Index Routing Agent=0.013)));2024-03-29T22:01:54.729Z X-MS-Exchange-Forest-ArrivalHubServer: mbx-dresden-01.secunet.de X-MS-Exchange-Organization-AuthSource: cas-essen-02.secunet.de X-MS-Exchange-Organization-AuthAs: Anonymous X-MS-Exchange-Organization-FromEntityHeader: Internet X-MS-Exchange-Organization-OriginalSize: 7441 X-MS-Exchange-Organization-HygienePolicy: Standard X-MS-Exchange-Organization-MessageLatency: SRV=cas-essen-02.secunet.de:TOTAL-FE=0.025|SMR=0.024(SMRPI=0.022(SMRPI-FrontendProxyAgent=0.022)) X-MS-Exchange-Organization-AVStamp-Enterprise: 1.0 X-MS-Exchange-Organization-Recipient-Limit-Verified: True X-MS-Exchange-Organization-TotalRecipientCount: 1 X-MS-Exchange-Organization-Rules-Execution-History: 0b0cf904-14ac-4724-8bdf-482ee6223cf2%%%fd34672d-751c-45ae-a963-ed177fcabe23%%%d8080257-b0c3-47b4-b0db-23bc0c8ddb3c%%%95e591a2-5d7d-4afa-b1d0-7573d6c0a5d9%%%f7d0f6bc-4dcc-4876-8c5d-b3d6ddbb3d55%%%16355082-c50b-4214-9c7d-d39575f9f79b X-MS-Exchange-Forest-RulesExecuted: mbx-dresden-01 X-MS-Exchange-Organization-RulesExecuted: mbx-dresden-01 X-MS-Exchange-Forest-IndexAgent-0: AQ0CZW4AAc4CAAAPAAADH4sIAAAAAAAEAKVSW0vcQBSe1WQv0diX0u dDC1ZxV3StLWzBUgrSPohCpT4uY3LWHUxmQmbiuv+iP7nfTFylYNuH hiHM5budM/Ozd67pivMhjT/QmaxpfDB+R4eHk8Px5GhMewfHRwf0Za 60k5p+SH0LyKI2jidpckJfLi6/U2nypmCyTVWZ2lnKZOWaWukbcqpk 62RZ0czUxHdcL6mS2S07Uo5qzljdsR16JZnnJEnzgmaNzpwymrQsOa fXsnx/PM0qZ6czpfNpfT91dmf3NTlDNxByc37y8UpmtlLOH8wszWpT tmFPv52e7wPmkZ+9pzZQqP/i6g1X+t53MVfZnNAQrrUsiqVXyjCxf4 76KC51/hTWhuyrrF7m4vJiFRkZ0+RMLq+Z1NuSGt3YxruBjnjO5HJJ 141vosxDq+fKgusQbaHc3DwdpYm30XzvyGimUt6yJW3Isra8T9+oZK mHtDQNWbmceF/6r4v1/NXd7u+HQr6aBSlfr/SxCr6T2hHazuH0as46 +FfGOro7pqpgaduocK/Z37XSWdHkjEeSGfhRwQ43MCS+rwqp9GOh/h CNohsji9BvVSKZ88/CH1uuFbfdPaE9eu4rlHXTnIspVN3ONqrTbnTi d3c//oOFV/wbYUjb/jmMTipjCs9Ok4ArkXJnlz6lyWiUJtVidG3chL LaA4RYE+vrIl7riA0MP4+iTtzviL4Q/c4gFiIW3Z7od0UvFkkkYkz6 YjAQCQbAOMUORPoixbIj1vAHIBY9LF6KOAoDgDXRDV4RxkCkgTKAcv SA2cQ+lo/cVysiwHBJxNazmsCDmIiN4NuKbAIfXHzgdt4atbX0AgXL Nj90oIzkUUCu/61M2L3AEhRgAIj8iFs1bALzmA1G0AzEfrKqrgW3HQ uTN6gofVDo+gIFRb752InDEqMbIVJHDLzyFm6q217ZLwZfdwROBQAA AQLxAjw/eG1sIHZlcnNpb249IjEuMCIgZW5jb2Rpbmc9InV0Zi0xNi I/Pg0KPFRhc2tTZXQ+DQogIDxWZXJzaW9uPjE1LjAuMC4wPC9WZXJz aW9uPg0KICA8VGFza3M+DQogICAgPFRhc2sgU3RhcnRJbmRleD0iNj QyIj4NCiAgICAgIDxUYXNrU3RyaW5nPldoZW4geW91IHBvc3QgdjUg cGxlYXNlIG1ha2Ugc3VyZSB0byBpbmNsdWRlIGEgY292ZXIgbGV0dG VyLCBleHBsYWluaW5nPC9UYXNrU3RyaW5nPg0KICAgICAgPEFzc2ln bmVlcz4NCiAgICAgICAgPEVtYWlsVXNlciBJZD0iYy12YW5rYXJAdG kuY29tIj5DaGludGFuIFZhbmthcjwvRW1haWxVc2VyPg0KICAgICAg PC9Bc3NpZ25lZXM+DQogICAgPC9UYXNrPg0KICA8L1Rhc2tzPg0KPC 9UYXNrU2V0PgEOzgFSZXRyaWV2ZXJPcGVyYXRvciwxMCwwO1JldHJp ZXZlck9wZXJhdG9yLDExLDA7UG9zdERvY1BhcnNlck9wZXJhdG9yLD EwLDA7UG9zdERvY1BhcnNlck9wZXJhdG9yLDExLDA7UG9zdFdvcmRC cmVha2VyRGlhZ25vc3RpY09wZXJhdG9yLDEwLDA7UG9zdFdvcmRCcm Vha2VyRGlhZ25vc3RpY09wZXJhdG9yLDExLDA7VHJhbnNwb3J0V3Jp dGVyUHJvZHVjZXIsMjAsNw== X-MS-Exchange-Forest-IndexAgent: 1 1312 X-MS-Exchange-Forest-EmailMessageHash: F51E6461 X-MS-Exchange-Forest-Language: en X-MS-Exchange-Organization-Processed-By-Journaling: Journal Agent On Wed, 27 Mar 2024 11:12:32 +0530 Chintan Vankar wrote: > CPTS module supports capturing timestamp for every packet it receives, > add a new function named "am65_cpts_find_rx_ts()" to get the timestamp > of received packets from CPTS FIFO. > > Add another function named "am65_cpts_rx_timestamp()" which internally > calls "am65_cpts_find_rx_ts()" function and timestamps the received > PTP packets. Maybe i'm unusually tied today but reading this patch without reading the next one makes no sense. I mean, you say: CPTS module supports capturing timestamp for every packet it receives... How is that relevant here. When you post v5 please make sure to include a cover letter, explaining the overall goal and impact of the series. > + list_del_init(&event->list); > + list_add(&event->list, &cpts->pool); list_move() ? -- pw-bot: cr
Powered by blists - more mailing lists