| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 30 Mar 2024 09:20:45 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Jeff Johnson <quic_jjohnson@...cinc.com>,
Johannes Berg <johannes@...solutions.net>,
"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] wifi: mac80211: remove ieee80211_set_hw_80211_encap()
On 3/29/24 13:27, Jeff Johnson wrote:
> While fixing kernel-doc issues it was discovered that the
> ieee80211_set_hw_80211_encap() prototype doesn't actually have an
> implementation, so remove it.
>
> Note the implementation was rmeoved in patch 6aea26ce5a4c ("mac80211:
> rework tx encapsulation offload API").
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>
Reviewed-by: Randy Dunlap <rdunlap@...radead.org>
Thanks.
> ---
> include/net/mac80211.h | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/include/net/mac80211.h b/include/net/mac80211.h
> index 353488ab94a2..e6a11a982ca8 100644
> --- a/include/net/mac80211.h
> +++ b/include/net/mac80211.h
> @@ -7478,18 +7478,6 @@ u32 ieee80211_calc_rx_airtime(struct ieee80211_hw *hw,
> u32 ieee80211_calc_tx_airtime(struct ieee80211_hw *hw,
> struct ieee80211_tx_info *info,
> int len);
> -/**
> - * ieee80211_set_hw_80211_encap - enable hardware encapsulation offloading.
> - *
> - * This function is used to notify mac80211 that a vif can be passed raw 802.3
> - * frames. The driver needs to then handle the 802.11 encapsulation inside the
> - * hardware or firmware.
> - *
> - * @vif: &struct ieee80211_vif pointer from the add_interface callback.
> - * @enable: indicate if the feature should be turned on or off
> - */
> -bool ieee80211_set_hw_80211_encap(struct ieee80211_vif *vif, bool enable);
> -
> /**
> * ieee80211_get_fils_discovery_tmpl - Get FILS discovery template.
> * @hw: pointer obtained from ieee80211_alloc_hw().
>
--
#Randy
X-sender: <linux-wireless+bounces-5637-peter.schumann=secunet.com@...r.kernel.org>
X-Receiver: <peter.schumann@...unet.com> ORCPT=rfc822;peter.schumann@...unet.com NOTIFY=NEVER; X-ExtendedProps=BQAVABYAAgAAAAUAFAARAJ05ab4WgQhHsqdZ7WUjHykPADUAAABNaWNyb3NvZnQuRXhjaGFuZ2UuVHJhbnNwb3J0LkRpcmVjdG9yeURhdGEuSXNSZXNvdXJjZQIAAAUAagAJAAEAAAAAAAAABQAWAAIAAAUAQwACAAAFAEYABwADAAAABQBHAAIAAAUAEgAPAGAAAAAvbz1zZWN1bmV0L291PUV4Y2hhbmdlIEFkbWluaXN0cmF0aXZlIEdyb3VwIChGWURJQk9IRjIzU1BETFQpL2NuPVJlY2lwaWVudHMvY249UGV0ZXIgU2NodW1hbm41ZTcFAAsAFwC+AAAAQ5IZ35DtBUiRVnd98bETxENOPURCNCxDTj1EYXRhYmFzZXMsQ049RXhjaGFuZ2UgQWRtaW5pc3RyYXRpdmUgR3JvdXAgKEZZRElCT0hGMjNTUERMVCksQ049QWRtaW5pc3RyYXRpdmUgR3JvdXBzLENOPXNlY3VuZXQsQ049TWljcm9zb2Z0IEV4Y2hhbmdlLENOPVNlcnZpY2VzLENOPUNvbmZpZ3VyYXRpb24sREM9c2VjdW5ldCxEQz1kZQUADgARAC7JU/le071Fhs0mWv1VtVsFAB0ADwAMAAAAbWJ4LWVzc2VuLTAxBQA8AAIAAA8ANgAAAE1pY3Jvc29mdC5FeGNoYW5nZS5UcmFuc3BvcnQuTWFpbFJlY2lwaWVudC5EaXNwbGF5TmFtZQ8ADwAAAFNjaHVtYW5uLCBQZXRlcgUADAACAAAFAGwAAgAABQBYABcASAAAAJ05ab4WgQhHsqdZ7WUjHylDTj1TY2h1bWFubiBQZXRlcixPVT1Vc2VycyxPVT1NaWdyYXRpb24sREM9c2VjdW5ldCxEQz1kZQUAJgACAAEFACIADwAxAAAAQXV0b1Jlc3BvbnNlU3VwcHJlc3M6IDANClRyYW5zbWl0SGlzdG9yeTogRmFsc2UNCg8ALwAAAE1pY3Jvc29mdC5FeGNoYW5nZS5UcmFuc3BvcnQuRXhwYW5zaW9uR3JvdXBUeXBlDwAVAAAATWVtYmVyc0dyb3VwRXhwYW5zaW9uBQAjAAIAAQ==
X-CreatedBy: MSExchange15
X-HeloDomain: a.mx.secunet.com
X-ExtendedProps: BQBjAAoAUJKmlidQ3AgFAGEACAABAAAABQA3AAIAAA8APAAAAE1pY3Jvc29mdC5FeGNoYW5nZS5UcmFuc3BvcnQuTWFpbFJlY2lwaWVudC5Pcmdhbml6YXRpb25TY29wZREAAAAAAAAAAAAAAAAAAAAAAAUASQACAAEFAAQAFCABAAAAGgAAAHBldGVyLnNjaHVtYW5uQHNlY3VuZXQuY29tBQAGAAIAAQUAKQACAAEPAAkAAABDSUF1ZGl0ZWQCAAEFAAIABwABAAAABQADAAcAAAAAAAUABQACAAEFAGIACgA1AAAA34oAAAUAZAAPAAMAAABIdWI=
X-Source: SMTP:Default MBX-ESSEN-02
X-SourceIPAddress: 62.96.220.36
X-EndOfInjectedXHeaders: 13821
Received: from cas-essen-01.secunet.de (10.53.40.201) by
mbx-essen-02.secunet.de (10.53.40.198) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2507.37; Sat, 30 Mar 2024 17:21:08 +0100
Received: from a.mx.secunet.com (62.96.220.36) by cas-essen-01.secunet.de
(10.53.40.201) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend
Transport; Sat, 30 Mar 2024 17:21:08 +0100
Received: from localhost (localhost [127.0.0.1])
by a.mx.secunet.com (Postfix) with ESMTP id 84D1C2087D
for <peter.schumann@...unet.com>; Sat, 30 Mar 2024 17:21:08 +0100 (CET)
X-Virus-Scanned: by secunet
X-Spam-Flag: NO
X-Spam-Score: -2.751
X-Spam-Level:
X-Spam-Status: No, score=-2.751 tagged_above=-999 required=2.1
tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1,
DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249,
MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001,
SPF_HELO_NONE=0.001, SPF_PASS=-0.001]
autolearn=unavailable autolearn_force=no
Authentication-Results: a.mx.secunet.com (amavisd-new);
dkim=pass (2048-bit key) header.d=infradead.org
Received: from a.mx.secunet.com ([127.0.0.1])
by localhost (a.mx.secunet.com [127.0.0.1]) (amavisd-new, port 10024)
with ESMTP id XakUJ4ZeZLBM for <peter.schumann@...unet.com>;
Sat, 30 Mar 2024 17:21:08 +0100 (CET)
Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=147.75.48.161; helo=sy.mirrors.kernel.org; envelope-from=linux-wireless+bounces-5637-peter.schumann=secunet.com@...r.kernel.org; receiver=peter.schumann@...unet.com
DKIM-Filter: OpenDKIM Filter v2.11.0 a.mx.secunet.com 6316F2084C
Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org [147.75.48.161])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by a.mx.secunet.com (Postfix) with ESMTPS id 6316F2084C
for <peter.schumann@...unet.com>; Sat, 30 Mar 2024 17:21:07 +0100 (CET)
Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by sy.mirrors.kernel.org (Postfix) with ESMTPS id B6AEFB21275
for <peter.schumann@...unet.com>; Sat, 30 Mar 2024 16:21:02 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
by smtp.subspace.kernel.org (Postfix) with ESMTP id 1E1243BBC2;
Sat, 30 Mar 2024 16:20:54 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
dkim=pass (2048-bit key) header.d=infradead.org header.i=@...radead.org header.b="Y2tp6sQa"
X-Original-To: linux-wireless@...r.kernel.org
Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by smtp.subspace.kernel.org (Postfix) with ESMTPS id 161DDEAC6;
Sat, 30 Mar 2024 16:20:50 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133
ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
t=1711815653; cv=none; b=mS6rVh5T/lZGK8wYPPxiInu59YJakJ7q1MXTMZzo+xYZwJGtSraU8JC5CpDXqofLK+Yp6Vt37MZIksZ4m3e1uACyQEnWLLtAT42lQXIqiaWAts8ZHDF3wNH6RRyLaSFLqHUPp5VjK6ZtJszYL/DUBgOMRVfEY5vozRoc0kwNnmg=
ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org;
s=arc-20240116; t=1711815653; c=relaxed/simple;
bh=JNC8qozkgWlE+Q6kdtHfr0XlvCkJCAqLu0MAE1TEAq8=;
h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:
In-Reply-To:Content-Type; b=m+WrL2f7eXA8QKozheTgtynh9tR1Mkhmu0+yvSb/Waw66WKvAnc6YogIpWcM2U7GOSLy5Zn2f9hWYhwc0eQp2nA3c6dARB4QsGQuBesijf+qVWtaWiw5AfCQf3A1pP6jGz+TFDZYo4VIzWrvKRIyD+NoxFUtE6EHzLeocwsMVw4=
ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@...radead.org header.b=Y2tp6sQa; arc=none smtp.client-ip=198.137.202.133
Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org
Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:
Message-ID:Sender:Reply-To:Content-ID:Content-Description;
bh=cDTgdTBVRUAZH0p6pwQw4KmwuQ/wNotFO0UsYy13RVs=; b=Y2tp6sQaaVk+sBrRRF0N2ANzw+
DJpIXWD4/mDjC2onipuC4uQQKeMs9aRsg/HT1VDwSIKGc3eP+vcLSjAkEbNMPmxTFdVHs6lWfg7Gw
MRd9D7hy/FJ+Fu6galftDA1RcyU74rR0nEHQh8Q4Cxw6xr3YPPMLQOXe5cjp/5oS3B9U2a8qsTQYh
/hPhHfrFJzmqDas7HWCJG9CrAVgTtD/r+gVTNc9TggRnbyE2zKQl5LZKhL3JxZMjhuQXGolftCOkc
NuOgeZu/HfHF4oCfUz6DmYc0A3cejB9ptDTqCWReNGWxbCCDxIVLAhruxGaoU9AB6p90lRi48gqLZ
zMJ8rFMw==;
Received: from [50.53.2.121] (helo=[192.168.254.15])
by bombadil.infradead.org with esmtpsa (Exim 4.97.1 #2 (Red Hat Linux))
id 1rqbRm-00000003mZz-0NbX;
Sat, 30 Mar 2024 16:20:46 +0000
Message-ID: <1c69304c-abaf-46e4-b58d-a4f9b30a8f5f@...radead.org>
Date: Sat, 30 Mar 2024 09:20:45 -0700
Precedence: bulk
X-Mailing-List: linux-wireless@...r.kernel.org
List-Id: <linux-wireless.vger.kernel.org>
List-Subscribe: <mailto:linux-wireless+subscribe@...r.kernel.org>
List-Unsubscribe: <mailto:linux-wireless+unsubscribe@...r.kernel.org>
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/2] wifi: mac80211: remove ieee80211_set_hw_80211_encap()
Content-Language: en-US
To: Jeff Johnson <quic_jjohnson@...cinc.com>,
Johannes Berg <johannes@...solutions.net>,
"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
References: <20240329-mac80211-kdoc-retval-v1-0-5e4d1ad6c250@...cinc.com>
<20240329-mac80211-kdoc-retval-v1-1-5e4d1ad6c250@...cinc.com>
From: Randy Dunlap <rdunlap@...radead.org>
In-Reply-To: <20240329-mac80211-kdoc-retval-v1-1-5e4d1ad6c250@...cinc.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Return-Path: linux-wireless+bounces-5637-peter.schumann=secunet.com@...r.kernel.org
X-MS-Exchange-Organization-OriginalArrivalTime: 30 Mar 2024 16:21:08.5633
(UTC)
X-MS-Exchange-Organization-Network-Message-Id: 43f778fb-9241-44a7-b57b-08dc50d5682a
X-MS-Exchange-Organization-OriginalClientIPAddress: 62.96.220.36
X-MS-Exchange-Organization-OriginalServerIPAddress: 10.53.40.201
X-MS-Exchange-Organization-Cross-Premises-Headers-Processed: cas-essen-01.secunet.de
X-MS-Exchange-Organization-OrderedPrecisionLatencyInProgress: LSRV=mbx-essen-02.secunet.de:TOTAL-HUB=0.400|SMR=0.326(SMRDE=0.002|SMRC=0.322(SMRCL=0.103|X-SMRCR=0.321))|CAT=0.073(CATRESL=0.027
(CATRESLP2R=0.006)|CATORES=0.042(CATRS=0.042(CATRS-Transport Rule
Agent=0.001|CATRS-Index Routing Agent=0.040
))|CATORT=0.001);2024-03-30T16:21:08.978Z
X-MS-Exchange-Forest-ArrivalHubServer: mbx-essen-02.secunet.de
X-MS-Exchange-Organization-AuthSource: cas-essen-01.secunet.de
X-MS-Exchange-Organization-AuthAs: Anonymous
X-MS-Exchange-Organization-FromEntityHeader: Internet
X-MS-Exchange-Organization-OriginalSize: 8513
X-MS-Exchange-Organization-HygienePolicy: Standard
X-MS-Exchange-Organization-MessageLatency: SRV=cas-essen-01.secunet.de:TOTAL-FE=0.014|SMR=0.009(SMRPI=0.007(SMRPI-FrontendProxyAgent=0.007))|SMS=0.004
X-MS-Exchange-Organization-Recipient-Limit-Verified: True
X-MS-Exchange-Organization-TotalRecipientCount: 1
X-MS-Exchange-Organization-Rules-Execution-History: 0b0cf904-14ac-4724-8bdf-482ee6223cf2%%%fd34672d-751c-45ae-a963-ed177fcabe23%%%d8080257-b0c3-47b4-b0db-23bc0c8ddb3c%%%95e591a2-5d7d-4afa-b1d0-7573d6c0a5d9%%%f7d0f6bc-4dcc-4876-8c5d-b3d6ddbb3d55%%%16355082-c50b-4214-9c7d-d39575f9f79b
X-MS-Exchange-Forest-RulesExecuted: mbx-essen-02
X-MS-Exchange-Organization-RulesExecuted: mbx-essen-02
X-MS-Exchange-Forest-IndexAgent-0: AQ0CZW4AAacEAAAPAAADH4sIAAAAAAAEAI1UbW8aRxCe4w44zsZ5af
0hVStNE7W1MRzmJTamkUWlqlWiqq2SSP2Ilrs9buNjl94dxkj9y/0P
nd0DYhLHqWUdO7PPPPO68+9+3at7f0jstbsX7W4fO71h97yJr3gU4S
sVy0xJXKYq58O6d4l/xSLhGIkbIad4xVPJk1aoAhRZtuAZihyXLMNQ
ZIG65ikPMY9ZTh+ujQXnfHDa7XTGGc/H8XJcCFwGbH50jHPyovLVnG
OoeCZ/yJEF+YIlyQpjds2RSUMymyd8xmXOcqFkEzOFKZ+RN3LuE0Bj
fqdwtdMPwCa2dMYJHKKQOGd5EOMZ46x7FvDnrB/g0dMZC0xYJt2UL1
V6hfkNmiCzRVIQqShKFAvxpz9fPj3eeH0jppKHLbprTVbD3Qq++Hsh
gvG7d4U40pKQgR+o2aWu/2t+LfiSjLXhaybDFf68kAmb44s0NIeRkF
HKQs5CX6VTY/Q2ZvIq8/XxElutlv6htIJkEfK25Hl7k4of4z/Y6WrM
9s+AO9RJamdARFMeNjUm5AnXKWZHreN1XqGgRFqtKTWXtT/BP/nEhe
mYDPkN9p73+oMBm1z0Wdf3+RnrdNjFoBuwAXZOT8/6/XUWn/Sh709O
Tu51NRph67x/Pmh2BnhiDmdat+h1bw1fwJJgnN6MmUhzMeNHWZ4ugv
wWIF5iI142TYnuMM3/p+k9fx/ZESc1WGFDfz9rLmSOCZfHP5qatRsN
84uNe18YAbhkE+p3zNJwyVJ+91DTy/bXfBvat7HIMFrIwODovMj001
YoVS6iFW6aULx2htciwoBJnHB6Y5nGpmyJBPF7G0oa5hnPfKKm554K
WhYoOQ8zzUovV1KQMkyKV6wNiXw3WiEzEfLNatGU27RUSnOdzvT5w0
xGFNoQv/+o/jriuaK6UhxRqmbGLwvDsVFFLKBXQptowoIrf8tVlHOo
B1wEjFYOkWi7iLN8QXFksVokoa4CibQaUBc51XVeU7TN70Sp5P7deG
e4Dfo00RgXgazHwQzPeiZwZyamxEwPPhtv9vNqnNOCpEh+5Tn+8vK3
N9vNvcKc0xUl5W94RvFyuK2RmuRM6JRMsd67oBqpgMI/Wm/FuqdXzT
Oz0rQETglsy4Jq8Q8lEkuWXQYoQ9WBchXcMnhlqFSgWrHAg6oNDp0J
RgcP9ghjQ7VmwdfgkWZjWymDWwOPzF2oEaYElQN4SFbG1jNWzgE8oC
9hSE8m+/DAhXpBXocD0tskWlA3TkvgmHhqjgVPoEy0BuC6FuxBjW5N
kC5lcWhc01UFDg3GIbBlEQOUrC8tAAtKmsqqaQ3YNfjCMS5I/x5P2B
2xbCI82LcoQqjAwe5tbUe0XF0Eq2I82sXZ+NVZ13T8nqmJXdVB6urt
g1fSObqfAzwrxEdatB2oOPAdmdhweGcLCEzxUDE9+MoxRTNW5aIRRW
socsPgFErbcow5pekWvSaqwqq4NelXiVOLsFdwuvDENkNS0/3yirYW
Xba1xqGOuPC4YuahGJ4itc1I2Eb5kEzuSuQ2M3GWTTDfkOZbg9RWum
LV7Zl8lYyLIkdCPjZjXIJH5f8AG1YsPGMJAAABCtkCPD94bWwgdmVy
c2lvbj0iMS4wIiBlbmNvZGluZz0idXRmLTE2Ij8+DQo8RW1haWxTZX
Q+DQogIDxWZXJzaW9uPjE1LjAuMC4wPC9WZXJzaW9uPg0KICA8RW1h
aWxzPg0KICAgIDxFbWFpbCBTdGFydEluZGV4PSIzNTgiPg0KICAgIC
AgPEVtYWlsU3RyaW5nPnF1aWNfampvaG5zb25AcXVpY2luYy5jb208
L0VtYWlsU3RyaW5nPg0KICAgIDwvRW1haWw+DQogICAgPEVtYWlsIF
N0YXJ0SW5kZXg9IjQxNSIgUG9zaXRpb249IlNpZ25hdHVyZSI+DQog
ICAgICA8RW1haWxTdHJpbmc+cmR1bmxhcEBpbmZyYWRlYWQub3JnPC
9FbWFpbFN0cmluZz4NCiAgICA8L0VtYWlsPg0KICA8L0VtYWlscz4N
CjwvRW1haWxTZXQ+AQytBzw/eG1sIHZlcnNpb249IjEuMCIgZW5jb2
Rpbmc9InV0Zi0xNiI/Pg0KPENvbnRhY3RTZXQ+DQogIDxWZXJzaW9u
PjE1LjAuMC4wPC9WZXJzaW9uPg0KICA8Q29udGFjdHM+DQogICAgPE
NvbnRhY3QgU3RhcnRJbmRleD0iMzQ0Ij4NCiAgICAgIDxQZXJzb24g
U3RhcnRJbmRleD0iMzQ0Ij4NCiAgICAgICAgPFBlcnNvblN0cmluZz
5KZWZmIEpvaG5zb248L1BlcnNvblN0cmluZz4NCiAgICAgIDwvUGVy
c29uPg0KICAgICAgPEVtYWlscz4NCiAgICAgICAgPEVtYWlsIFN0YX
J0SW5kZXg9IjM1OCI+DQogICAgICAgICAgPEVtYWlsU3RyaW5nPnF1
aWNfampvaG5zb25AcXVpY2luYy5jb208L0VtYWlsU3RyaW5nPg0KIC
AgICAgICA8L0VtYWlsPg0KICAgICAgPC9FbWFpbHM+DQogICAgICA8
Q29udGFjdFN0cmluZz5KZWZmIEpvaG5zb24gJmx0O3F1aWNfampvaG
5zb25AcXVpY2luYy5jb208L0NvbnRhY3RTdHJpbmc+DQogICAgPC9D
b250YWN0Pg0KICAgIDxDb250YWN0IFN0YXJ0SW5kZXg9IjQwMSIgUG
9zaXRpb249IlNpZ25hdHVyZSI+DQogICAgICA8UGVyc29uIFN0YXJ0
SW5kZXg9IjQwMSIgUG9zaXRpb249IlNpZ25hdHVyZSI+DQogICAgIC
AgIDxQZXJzb25TdHJpbmc+UmFuZHkgRHVubGFwPC9QZXJzb25TdHJp
bmc+DQogICAgICA8L1BlcnNvbj4NCiAgICAgIDxFbWFpbHM+DQogIC
AgICAgIDxFbWFpbCBTdGFydEluZGV4PSI0MTUiIFBvc2l0aW9uPSJT
aWduYXR1cmUiPg0KICAgICAgICAgIDxFbWFpbFN0cmluZz5yZHVubG
FwQGluZnJhZGVhZC5vcmc8L0VtYWlsU3RyaW5nPg0KICAgICAgICA8
L0VtYWlsPg0KICAgICAgPC9FbWFpbHM+DQogICAgICA8Q29udGFjdF
N0cmluZz5SYW5keSBEdW5sYXAgJmx0O3JkdW5sYXBAaW5mcmFkZWFk
Lm9yZzwvQ29udGFjdFN0cmluZz4NCiAgICA8L0NvbnRhY3Q+DQogID
wvQ29udGFjdHM+DQo8L0NvbnRhY3RTZXQ+AQ7PAVJldHJpZXZlck9w
ZXJhdG9yLDEwLDE7UmV0cmlldmVyT3BlcmF0b3IsMTEsMjtQb3N0RG
9jUGFyc2VyT3BlcmF0b3IsMTAsMTtQb3N0RG9jUGFyc2VyT3BlcmF0
b3IsMTEsMDtQb3N0V29yZEJyZWFrZXJEaWFnbm9zdGljT3BlcmF0b3
IsMTAsMjtQb3N0V29yZEJyZWFrZXJEaWFnbm9zdGljT3BlcmF0b3Is
MTEsMDtUcmFuc3BvcnRXcml0ZXJQcm9kdWNlciwyMCwxOQ==
X-MS-Exchange-Forest-IndexAgent: 1 2707
X-MS-Exchange-Forest-EmailMessageHash: 2EE2F216
X-MS-Exchange-Forest-Language: en
X-MS-Exchange-Organization-Processed-By-Journaling: Journal Agent
On 3/29/24 13:27, Jeff Johnson wrote:
> While fixing kernel-doc issues it was discovered that the
> ieee80211_set_hw_80211_encap() prototype doesn't actually have an
> implementation, so remove it.
>
> Note the implementation was rmeoved in patch 6aea26ce5a4c ("mac80211:
> rework tx encapsulation offload API").
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>
Reviewed-by: Randy Dunlap <rdunlap@...radead.org>
Thanks.
> ---
> include/net/mac80211.h | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/include/net/mac80211.h b/include/net/mac80211.h
> index 353488ab94a2..e6a11a982ca8 100644
> --- a/include/net/mac80211.h
> +++ b/include/net/mac80211.h
> @@ -7478,18 +7478,6 @@ u32 ieee80211_calc_rx_airtime(struct ieee80211_hw *hw,
> u32 ieee80211_calc_tx_airtime(struct ieee80211_hw *hw,
> struct ieee80211_tx_info *info,
> int len);
> -/**
> - * ieee80211_set_hw_80211_encap - enable hardware encapsulation offloading.
> - *
> - * This function is used to notify mac80211 that a vif can be passed raw 802.3
> - * frames. The driver needs to then handle the 802.11 encapsulation inside the
> - * hardware or firmware.
> - *
> - * @vif: &struct ieee80211_vif pointer from the add_interface callback.
> - * @enable: indicate if the feature should be turned on or off
> - */
> -bool ieee80211_set_hw_80211_encap(struct ieee80211_vif *vif, bool enable);
> -
> /**
> * ieee80211_get_fils_discovery_tmpl - Get FILS discovery template.
> * @hw: pointer obtained from ieee80211_alloc_hw().
>
--
#Randy
X-sender: <netdev+bounces-83514-steffen.klassert=secunet.com@...r.kernel.org>
X-Receiver: <steffen.klassert@...unet.com> ORCPT=rfc822;steffen.klassert@...unet.com
X-CreatedBy: MSExchange15
X-HeloDomain: mbx-dresden-01.secunet.de
X-ExtendedProps: BQBjAAoAiJKmlidQ3AgFADcAAgAADwA8AAAATWljcm9zb2Z0LkV4Y2hhbmdlLlRyYW5zcG9ydC5NYWlsUmVjaXBpZW50Lk9yZ2FuaXphdGlvblNjb3BlEQAAAAAAAAAAAAAAAAAAAAAADwA/AAAATWljcm9zb2Z0LkV4Y2hhbmdlLlRyYW5zcG9ydC5EaXJlY3RvcnlEYXRhLk1haWxEZWxpdmVyeVByaW9yaXR5DwADAAAATG93
X-Source: SMTP:Default MBX-ESSEN-02
X-SourceIPAddress: 10.53.40.199
X-EndOfInjectedXHeaders: 9005
Received: from mbx-dresden-01.secunet.de (10.53.40.199) by
mbx-essen-02.secunet.de (10.53.40.198) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2507.37; Sat, 30 Mar 2024 17:21:07 +0100
Received: from a.mx.secunet.com (62.96.220.36) by cas-essen-02.secunet.de
(10.53.40.202) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend
Transport; Sat, 30 Mar 2024 17:21:06 +0100
Received: from localhost (localhost [127.0.0.1])
by a.mx.secunet.com (Postfix) with ESMTP id EB5762087D
for <steffen.klassert@...unet.com>; Sat, 30 Mar 2024 17:21:06 +0100 (CET)
X-Virus-Scanned: by secunet
X-Spam-Flag: NO
X-Spam-Score: -5.051
X-Spam-Level:
X-Spam-Status: No, score=-5.051 tagged_above=-999 required=2.1
tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1,
DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249,
MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: a.mx.secunet.com (amavisd-new);
dkim=pass (2048-bit key) header.d=infradead.org
Received: from a.mx.secunet.com ([127.0.0.1])
by localhost (a.mx.secunet.com [127.0.0.1]) (amavisd-new, port 10024)
with ESMTP id vFw2yZd9nBpK for <steffen.klassert@...unet.com>;
Sat, 30 Mar 2024 17:21:05 +0100 (CET)
Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=139.178.88.99; helo=sv.mirrors.kernel.org; envelope-from=netdev+bounces-83514-steffen.klassert=secunet.com@...r.kernel.org; receiver=steffen.klassert@...unet.com
DKIM-Filter: OpenDKIM Filter v2.11.0 a.mx.secunet.com 524E72084C
Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org [139.178.88.99])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by a.mx.secunet.com (Postfix) with ESMTPS id 524E72084C
for <steffen.klassert@...unet.com>; Sat, 30 Mar 2024 17:21:05 +0100 (CET)
Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by sv.mirrors.kernel.org (Postfix) with ESMTPS id F0167283247
for <steffen.klassert@...unet.com>; Sat, 30 Mar 2024 16:21:02 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
by smtp.subspace.kernel.org (Postfix) with ESMTP id 3B4A63BBC8;
Sat, 30 Mar 2024 16:20:54 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
dkim=pass (2048-bit key) header.d=infradead.org header.i=@...radead.org header.b="Y2tp6sQa"
X-Original-To: netdev@...r.kernel.org
Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by smtp.subspace.kernel.org (Postfix) with ESMTPS id 161DDEAC6;
Sat, 30 Mar 2024 16:20:50 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133
ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
t=1711815653; cv=none; b=mS6rVh5T/lZGK8wYPPxiInu59YJakJ7q1MXTMZzo+xYZwJGtSraU8JC5CpDXqofLK+Yp6Vt37MZIksZ4m3e1uACyQEnWLLtAT42lQXIqiaWAts8ZHDF3wNH6RRyLaSFLqHUPp5VjK6ZtJszYL/DUBgOMRVfEY5vozRoc0kwNnmg=
ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org;
s=arc-20240116; t=1711815653; c=relaxed/simple;
bh=JNC8qozkgWlE+Q6kdtHfr0XlvCkJCAqLu0MAE1TEAq8=;
h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:
In-Reply-To:Content-Type; b=m+WrL2f7eXA8QKozheTgtynh9tR1Mkhmu0+yvSb/Waw66WKvAnc6YogIpWcM2U7GOSLy5Zn2f9hWYhwc0eQp2nA3c6dARB4QsGQuBesijf+qVWtaWiw5AfCQf3A1pP6jGz+TFDZYo4VIzWrvKRIyD+NoxFUtE6EHzLeocwsMVw4=
ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@...radead.org header.b=Y2tp6sQa; arc=none smtp.client-ip=198.137.202.133
Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org
Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:
Message-ID:Sender:Reply-To:Content-ID:Content-Description;
bh=cDTgdTBVRUAZH0p6pwQw4KmwuQ/wNotFO0UsYy13RVs=; b=Y2tp6sQaaVk+sBrRRF0N2ANzw+
DJpIXWD4/mDjC2onipuC4uQQKeMs9aRsg/HT1VDwSIKGc3eP+vcLSjAkEbNMPmxTFdVHs6lWfg7Gw
MRd9D7hy/FJ+Fu6galftDA1RcyU74rR0nEHQh8Q4Cxw6xr3YPPMLQOXe5cjp/5oS3B9U2a8qsTQYh
/hPhHfrFJzmqDas7HWCJG9CrAVgTtD/r+gVTNc9TggRnbyE2zKQl5LZKhL3JxZMjhuQXGolftCOkc
NuOgeZu/HfHF4oCfUz6DmYc0A3cejB9ptDTqCWReNGWxbCCDxIVLAhruxGaoU9AB6p90lRi48gqLZ
zMJ8rFMw==;
Received: from [50.53.2.121] (helo=[192.168.254.15])
by bombadil.infradead.org with esmtpsa (Exim 4.97.1 #2 (Red Hat Linux))
id 1rqbRm-00000003mZz-0NbX;
Sat, 30 Mar 2024 16:20:46 +0000
Message-ID: <1c69304c-abaf-46e4-b58d-a4f9b30a8f5f@...radead.org>
Date: Sat, 30 Mar 2024 09:20:45 -0700
Precedence: bulk
X-Mailing-List: netdev@...r.kernel.org
List-Id: <netdev.vger.kernel.org>
List-Subscribe: <mailto:netdev+subscribe@...r.kernel.org>
List-Unsubscribe: <mailto:netdev+unsubscribe@...r.kernel.org>
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/2] wifi: mac80211: remove ieee80211_set_hw_80211_encap()
Content-Language: en-US
To: Jeff Johnson <quic_jjohnson@...cinc.com>,
Johannes Berg <johannes@...solutions.net>,
"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
References: <20240329-mac80211-kdoc-retval-v1-0-5e4d1ad6c250@...cinc.com>
<20240329-mac80211-kdoc-retval-v1-1-5e4d1ad6c250@...cinc.com>
From: Randy Dunlap <rdunlap@...radead.org>
In-Reply-To: <20240329-mac80211-kdoc-retval-v1-1-5e4d1ad6c250@...cinc.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Return-Path: netdev+bounces-83514-steffen.klassert=secunet.com@...r.kernel.org
X-MS-Exchange-Organization-OriginalArrivalTime: 30 Mar 2024 16:21:06.9955
(UTC)
X-MS-Exchange-Organization-Network-Message-Id: 85e27eb5-d716-49d2-7d7c-08dc50d5673b
X-MS-Exchange-Organization-OriginalClientIPAddress: 62.96.220.36
X-MS-Exchange-Organization-OriginalServerIPAddress: 10.53.40.202
X-MS-Exchange-Organization-Cross-Premises-Headers-Processed: cas-essen-02.secunet.de
X-MS-Exchange-Organization-OrderedPrecisionLatencyInProgress: LSRV=cas-essen-02.secunet.de:TOTAL-FE=0.009|SMR=0.010(SMRPI=0.007(SMRPI-FrontendProxyAgent=0.007));2024-03-30T16:21:07.005Z
X-MS-Exchange-Forest-ArrivalHubServer: mbx-essen-02.secunet.de
X-MS-Exchange-Organization-AuthSource: cas-essen-02.secunet.de
X-MS-Exchange-Organization-AuthAs: Anonymous
X-MS-Exchange-Organization-OriginalSize: 8457
X-MS-Exchange-Organization-Transport-Properties: DeliveryPriority=Low
X-MS-Exchange-Organization-Prioritization: 2:ShadowRedundancy
X-MS-Exchange-Organization-IncludeInSla: False:ShadowRedundancy
On 3/29/24 13:27, Jeff Johnson wrote:
> While fixing kernel-doc issues it was discovered that the
> ieee80211_set_hw_80211_encap() prototype doesn't actually have an
> implementation, so remove it.
>
> Note the implementation was rmeoved in patch 6aea26ce5a4c ("mac80211:
> rework tx encapsulation offload API").
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>
Reviewed-by: Randy Dunlap <rdunlap@...radead.org>
Thanks.
> ---
> include/net/mac80211.h | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/include/net/mac80211.h b/include/net/mac80211.h
> index 353488ab94a2..e6a11a982ca8 100644
> --- a/include/net/mac80211.h
> +++ b/include/net/mac80211.h
> @@ -7478,18 +7478,6 @@ u32 ieee80211_calc_rx_airtime(struct ieee80211_hw *hw,
> u32 ieee80211_calc_tx_airtime(struct ieee80211_hw *hw,
> struct ieee80211_tx_info *info,
> int len);
> -/**
> - * ieee80211_set_hw_80211_encap - enable hardware encapsulation offloading.
> - *
> - * This function is used to notify mac80211 that a vif can be passed raw 802.3
> - * frames. The driver needs to then handle the 802.11 encapsulation inside the
> - * hardware or firmware.
> - *
> - * @vif: &struct ieee80211_vif pointer from the add_interface callback.
> - * @enable: indicate if the feature should be turned on or off
> - */
> -bool ieee80211_set_hw_80211_encap(struct ieee80211_vif *vif, bool enable);
> -
> /**
> * ieee80211_get_fils_discovery_tmpl - Get FILS discovery template.
> * @hw: pointer obtained from ieee80211_alloc_hw().
>
--
#Randy
Powered by blists - more mailing lists