linux-kernel - Re: [PATCH v4] x86/mm/ident_map: On UV systems, use gbpages only where full GB page should be mapped.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871q7r12d2.fsf@email.froward.int.ebiederm.org>
Date: Sat, 30 Mar 2024 22:55:53 -0500
From: "Eric W. Biederman" <ebiederm@...ssion.com>
To: Ingo Molnar <mingo@...nel.org>
Cc: Pavin Joseph <me@...injoseph.com>,  Steve Wahl <steve.wahl@....com>,
  Dave Hansen <dave.hansen@...ux.intel.com>,  Andy Lutomirski
 <luto@...nel.org>,  Peter Zijlstra <peterz@...radead.org>,  Thomas
 Gleixner <tglx@...utronix.de>,  Ingo Molnar <mingo@...hat.com>,  Borislav
 Petkov <bp@...en8.de>,  x86@...nel.org,  "H. Peter Anvin" <hpa@...or.com>,
  linux-kernel@...r.kernel.org,  Linux regressions mailing list
 <regressions@...ts.linux.dev>,  stable@...r.kernel.org,  Eric Hagberg
 <ehagberg@...il.com>,  Simon Horman <horms@...ge.net.au>,  Dave Young
 <dyoung@...hat.com>,  Sarah Brofeldt <srhb@....dk>,  Russ Anderson
 <rja@....com>,  Dimitri Sivanich <sivanich@....com>,  Hou Wenlong
 <houwenlong.hwl@...group.com>,  Andrew Morton <akpm@...ux-foundation.org>,
  Baoquan He <bhe@...hat.com>,  Yuntao Wang <ytcoode@...il.com>,  Bjorn
 Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH v4] x86/mm/ident_map: On UV systems, use gbpages only
 where full GB page should be mapped.

Ingo Molnar <mingo@...nel.org> writes:

> * Pavin Joseph <me@...injoseph.com> wrote:
>
>> On 3/29/24 13:45, Ingo Molnar wrote:
>> > Just to clarify, we have the following 3 upstream (and soon to be upstream) versions:
>> > 
>> >   v1: pre-d794734c9bbf kernels
>> >   v2: d794734c9bbf x86/mm/ident_map: Use gbpages only where full GB page should be mapped.
>> >   v3: c567f2948f57 Revert "x86/mm/ident_map: Use gbpages only where full GB page should be mapped."
>> > 
>> > Where v1 and v3 ought to be the same in behavior.
>> > 
>> > So how does the failure matrix look like on your systems? Is my
>> > understanding accurate:
>
>> Slight correction:
>> 
>>    regular boot  | regular kexec | nogbpages boot | nogbpages kexec boot
>> -----------------|---------------|----------------|------------------
>> v1:       OK     | OK            | OK             | FAIL
>> v2:       OK     | FAIL          | OK             | FAIL
>
> Thanks!
>
> So the question is now: does anyone have a theory about in what fashion 
> the kexec nogbpages bootup differs from the regular nogbpages bootup to 
> break on your system?
>
> I'd have expected the described root cause of the firmware not properly 
> enumerating all memory areas that need to be mapped to cause trouble on 
> regular, non-kexec nogbpages bootups too. What makes the kexec bootup 
> special to trigger this crash?

My blind hunch would be something in the first 1MiB being different.
The first 1MiB is where all of the historical stuff is and where
I have seen historical memory maps be less than perfectly accurate.

Changing what is mapped being the difference between success and failure
sounds like some place that is dark and hard to debug a page fault is
being triggered and that in turn becoming a triple fault.

Paving Joseph is there any chance you can provide your memory map?
Perhaps just cat /proc/iomem?

If I have something to go one other than works/doesn't work I can
probably say something intelligent.

Eric