linux-kernel - Re: [PATCH] HID: i2c-hid: Revert to await reset ACK before reading report descriptor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4fe2450a-51ca-4161-9006-1325c2a16c07@kl.wtf>
Date: Sun, 31 Mar 2024 20:23:03 +0200
From: Kenny Levinsen <kl@...wtf>
To: Jiri Kosina <jikos@...nel.org>,
 Benjamin Tissoires <benjamin.tissoires@...hat.com>
Cc: Douglas Anderson <dianders@...omium.org>,
 Hans de Goede <hdegoede@...hat.com>, linux-input@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: i2c-hid: Revert to await reset ACK before reading
 report descriptor

On 3/31/24 3:23 PM, Kenny Levinsen wrote:
> diff --git a/drivers/hid/i2c-hid/i2c-hid-core.c b/drivers/hid/i2c-hid/i2c-hid-core.c
> index 2df1ab3c31cc..be5d661dde41 100644
> --- a/drivers/hid/i2c-hid/i2c-hid-core.c
> +++ b/drivers/hid/i2c-hid/i2c-hid-core.c
> @@ -737,7 +737,9 @@ static int i2c_hid_parse(struct hid_device *hid)
>   		ret = i2c_hid_start_hwreset(ihid);
>   		if (ret)
>   			msleep(1000);
> +		ret = i2c_hid_finish_hwreset(ihid);

Ah, missed the check to only call i2c_hid_finish_hwreset if 
i2c_hid_start_hwreset succeeded, v2 incoming.