linux-kernel - Re: [syzbot] [bpf?] possible deadlock in kvfree_call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZgkQBA-Lsk9mxZJ3@pc636>
Date: Sun, 31 Mar 2024 09:25:56 +0200
From: Uladzislau Rezki <urezki@...il.com>
To: Hillf Danton <hdanton@...a.com>
Cc: Uladzislau Rezki <urezki@...il.com>,
	syzbot <syzbot+1fa663a2100308ab6eab@...kaller.appspotmail.com>,
	Alexei Starovoitov <alexei.starovoitov@...il.com>,
	"Paul E. McKenney" <paulmck@...nel.org>,
	linux-kernel@...r.kernel.org, syzkaller-bugs@...glegroups.com
Subject: Re: [syzbot] [bpf?] possible deadlock in kvfree_call_rcu

On Sun, Mar 31, 2024 at 02:23:14PM +0800, Hillf Danton wrote:
> On Sat, 30 Mar 2024 18:55:41 +0100 Uladzislau Rezki <urezki@...il.com>
> > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> > index d9642dd06c25..8867aac3668c 100644
> > --- a/kernel/rcu/tree.c
> > +++ b/kernel/rcu/tree.c
> > @@ -3467,19 +3467,19 @@ void kvfree_call_rcu(struct rcu_head *head, void *ptr)
> >  	 */
> >  	kmemleak_ignore(ptr);
> >  
> > -	// Set timer to drain after KFREE_DRAIN_JIFFIES.
> > -	if (rcu_scheduler_active == RCU_SCHEDULER_RUNNING)
> > -		schedule_delayed_monitor_work(krcp);
> > -
> 
> This is not enough at least WRT run_page_cache_worker() [1]
> 
> [1] https://lore.kernel.org/lkml/0000000000007a44120614e27cb7@google.com/
> 
page-cache-worker should be move out of the krcp-lock also. I will
update the patch.

--
Uladzislau Rezki