linux-kernel - Re: [PATCH] ASoC: dt-bindings: mt2701-wm8960: Convert to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240401151414.GA706943-robh@kernel.org>
Date: Mon, 1 Apr 2024 10:14:14 -0500
From: Rob Herring <robh@...nel.org>
To: Kartik Agarwala <agarwala.kartik@...il.com>
Cc: lgirdwood@...il.com, broonie@...nel.org,
	krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
	matthias.bgg@...il.com, angelogioacchino.delregno@...labora.com,
	linux-sound@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH] ASoC: dt-bindings: mt2701-wm8960: Convert to dtschema

On Mon, Apr 01, 2024 at 10:05:05AM +0530, Kartik Agarwala wrote:
> Convert mt2701-wm890 bindings from text to dtschema. This is used by MediaTek mt77623a/n SoC.

Wrap lines at 75.

> 
> Signed-off-by: Kartik Agarwala <agarwala.kartik@...il.com>
> ---
>  .../sound/mediatek,mt2701-wm8960.yaml         | 59 +++++++++++++++++++
>  .../bindings/sound/mt2701-wm8960.txt          | 24 --------
>  2 files changed, 59 insertions(+), 24 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/sound/mediatek,mt2701-wm8960.yaml
>  delete mode 100644 Documentation/devicetree/bindings/sound/mt2701-wm8960.txt
> 
> diff --git a/Documentation/devicetree/bindings/sound/mediatek,mt2701-wm8960.yaml b/Documentation/devicetree/bindings/sound/mediatek,mt2701-wm8960.yaml
> new file mode 100644
> index 000000000..771f14a59
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/mediatek,mt2701-wm8960.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/mediatek,mt2701-wm8960.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek MT2701 with WM8960 CODEC
> +
> +maintainers:
> +  - Kartik Agarwala <agarwala.kartik@...il.com>
> +
> +properties:
> +  compatible:
> +    const: mediatek,mt2701-wm8960-machine
> +
> +  mediatek,platform:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description: The phandle of MT2701 ASoC platform.
> +
> +  audio-routing:
> +    $ref: /schemas/types.yaml#/definitions/non-unique-string-array
> +    description: |

Don't need '|'.

> +      A list of the connections between audio components. Each entry is a
> +      pair of strings, the first being the connection's sink, the second
> +      being the connection's source.
> +
> +  mediatek,audio-codec:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description: The phandle of the WM8960 audio codec.
> +  
> +  pinctrl-names:
> +    const: default
> +
> +  pinctrl-0: true

You can drop pinctrl properties. Those are implicitly supported.

> +
> +unevaluatedProperties: false
> +
> +required:
> +  - compatible
> +  - mediatek,platform
> +  - audio-routing
> +  - mediatek,audio-codec
> +  - pinctrl-names
> +  - pinctrl-0
> +
> +examples:
> +  - |
> +    sound {
> +        compatible = "mediatek,mt2701-wm8960-machine";
> +        mediatek,platform = <&afe>;
> +        audio-routing =
> +            "Headphone", "HP_L",
> +            "Headphone", "HP_R",
> +            "LINPUT1", "AMIC",
> +            "RINPUT1", "AMIC";
> +        mediatek,audio-codec = <&wm8960>;
> +        pinctrl-names = "default";
> +        pinctrl-0 = <&aud_pins_default>;
> +    };