linux-kernel - Re: [PATCH v2 27/27] kselftest/riscv: kselftest for user mode cfi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKC1njR3+mxZHEig8iZo+=0k_VFWg9ZYO3pzGi6s=uLZ5hOkKw@mail.gmail.com>
Date: Mon, 1 Apr 2024 10:55:54 -0700
From: Deepak Gupta <debug@...osinc.com>
To: Muhammad Usama Anjum <usama.anjum@...labora.com>
Cc: paul.walmsley@...ive.com, rick.p.edgecombe@...el.com, broonie@...nel.org, 
	Szabolcs.Nagy@....com, kito.cheng@...ive.com, keescook@...omium.org, 
	ajones@...tanamicro.com, conor.dooley@...rochip.com, cleger@...osinc.com, 
	atishp@...shpatra.org, alex@...ti.fr, bjorn@...osinc.com, 
	alexghiti@...osinc.com, samuel.holland@...ive.com, conor@...nel.org, 
	linux-doc@...r.kernel.org, linux-riscv@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, linux-mm@...ck.org, 
	linux-arch@...r.kernel.org, linux-kselftest@...r.kernel.org, corbet@....net, 
	tech-j-ext@...ts.risc-v.org, palmer@...belt.com, aou@...s.berkeley.edu, 
	robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org, oleg@...hat.com, 
	akpm@...ux-foundation.org, arnd@...db.de, ebiederm@...ssion.com, 
	Liam.Howlett@...cle.com, vbabka@...e.cz, lstoakes@...il.com, shuah@...nel.org, 
	brauner@...nel.org, andy.chiu@...ive.com, jerry.shih@...ive.com, 
	hankuan.chen@...ive.com, greentime.hu@...ive.com, evan@...osinc.com, 
	xiao.w.wang@...el.com, charlie@...osinc.com, apatel@...tanamicro.com, 
	mchitale@...tanamicro.com, dbarboza@...tanamicro.com, sameo@...osinc.com, 
	shikemeng@...weicloud.com, willy@...radead.org, vincent.chen@...ive.com, 
	guoren@...nel.org, samitolvanen@...gle.com, songshuaishuai@...ylab.org, 
	gerg@...nel.org, heiko@...ech.de, bhe@...hat.com, 
	jeeheng.sia@...rfivetech.com, cyy@...self.name, maskray@...gle.com, 
	ancientmodern4@...il.com, mathis.salmen@...sal.de, cuiyunhui@...edance.com, 
	bgray@...ux.ibm.com, mpe@...erman.id.au, baruch@...s.co.il, alx@...nel.org, 
	david@...hat.com, catalin.marinas@....com, revest@...omium.org, 
	josh@...htriplett.org, shr@...kernel.io, deller@....de, omosnace@...hat.com, 
	ojeda@...nel.org, jhubbard@...dia.com
Subject: Re: [PATCH v2 27/27] kselftest/riscv: kselftest for user mode cfi

On Mon, Apr 1, 2024 at 10:34 AM Deepak Gupta <debug@...osinc.com> wrote:
>
> On Mon, Apr 1, 2024 at 2:48 AM Muhammad Usama Anjum
> <usama.anjum@...labora.com> wrote:
> >
> > >>> Signed-off-by: Deepak Gupta <debug@...osinc.com>
> > >>> ---
> > >>>  tools/testing/selftests/riscv/Makefile        |   2 +-
> > >>>  tools/testing/selftests/riscv/cfi/Makefile    |  10 +
> > >>>  .../testing/selftests/riscv/cfi/cfi_rv_test.h |  85 ++++
> > >>>  .../selftests/riscv/cfi/riscv_cfi_test.c      |  91 +++++
> > >>>  .../testing/selftests/riscv/cfi/shadowstack.c | 376 ++++++++++++++++++
> > >>>  .../testing/selftests/riscv/cfi/shadowstack.h |  39 ++
> > >> Please add generated binaries in the .gitignore files.
> > >
> > > hmm...
> > > I don't see binary as part of the patch. Which file are you referring
> > > to here being binary?
> > shadowstack would be generated by the build. Create a .gitignore file and
> > add it there. For example, look at
> > tools/testing/selftests/riscv/vector/.gitignore to understand.
>
> It's `shadowstack.c` (a C source file) and not a binary file.

Nevermind. I think what you want me to do is add a rule in `.gitignore`.
I was thinking otherwise (that somehow you're seeing a binary file in
patch set).

Thanks. Will do that in the next iteration.