linux-kernel - Re: [PATCH] fpga: dfl: afu: remove unused member pdata from struct dfl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <df3382349cbb72fc1604d3e305edbad9e81505a4.camel@intel.com>
Date: Mon, 1 Apr 2024 18:27:08 +0000
From: "Colberg, Peter" <peter.colberg@...el.com>
To: "yilun.xu@...ux.intel.com" <yilun.xu@...ux.intel.com>
CC: "Xu, Yilun" <yilun.xu@...el.com>, "linux-fpga@...r.kernel.org"
	<linux-fpga@...r.kernel.org>, "mdf@...nel.org" <mdf@...nel.org>, "Wu, Hao"
	<hao.wu@...el.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "russ.weight@...ux.dev"
	<russ.weight@...ux.dev>, "Pagani, Marco" <marpagan@...hat.com>, "Rix, Tom"
	<trix@...hat.com>, "matthew.gerlach@...ux.intel.com"
	<matthew.gerlach@...ux.intel.com>
Subject: Re: [PATCH] fpga: dfl: afu: remove unused member pdata from struct
 dfl_afu

On Mon, 2024-04-01 at 22:57 +0800, Xu Yilun wrote:
> On Thu, Mar 28, 2024 at 07:54:17PM -0400, Peter Colberg wrote:
> > The member pdata was added to struct dfl_afu in commit 857a26222ff7
> > ("fpga: dfl: afu: add afu sub feature support") and is set in function
> > afu_dev_init() but otherwise never used.
> 
> Could you also help check if dfl_fme has the same issue?

Indeed, thank you for pointing this out.

Peter

> 
> Thanks,
> Yilun
> 
> > 
> > Signed-off-by: Peter Colberg <peter.colberg@...el.com>
> > Reviewed-by: Matthew Gerlach <matthew.gerlach@...ux.intel.com>
> > ---
> >  drivers/fpga/dfl-afu-main.c | 2 --
> >  drivers/fpga/dfl-afu.h      | 3 ---
> >  2 files changed, 5 deletions(-)
> > 
> > diff --git a/drivers/fpga/dfl-afu-main.c b/drivers/fpga/dfl-afu-main.c
> > index c0a75ca360d6..6b97c073849e 100644
> > --- a/drivers/fpga/dfl-afu-main.c
> > +++ b/drivers/fpga/dfl-afu-main.c
> > @@ -858,8 +858,6 @@ static int afu_dev_init(struct platform_device *pdev)
> >  	if (!afu)
> >  		return -ENOMEM;
> >  
> > -	afu->pdata = pdata;
> > -
> >  	mutex_lock(&pdata->lock);
> >  	dfl_fpga_pdata_set_private(pdata, afu);
> >  	afu_mmio_region_init(pdata);
> > diff --git a/drivers/fpga/dfl-afu.h b/drivers/fpga/dfl-afu.h
> > index 674e9772f0ea..7bef3e300aa2 100644
> > --- a/drivers/fpga/dfl-afu.h
> > +++ b/drivers/fpga/dfl-afu.h
> > @@ -67,7 +67,6 @@ struct dfl_afu_dma_region {
> >   * @regions: the mmio region linked list of this afu feature device.
> >   * @dma_regions: root of dma regions rb tree.
> >   * @num_umsgs: num of umsgs.
> > - * @pdata: afu platform device's pdata.
> >   */
> >  struct dfl_afu {
> >  	u64 region_cur_offset;
> > @@ -75,8 +74,6 @@ struct dfl_afu {
> >  	u8 num_umsgs;
> >  	struct list_head regions;
> >  	struct rb_root dma_regions;
> > -
> > -	struct dfl_feature_platform_data *pdata;
> >  };
> >  
> >  /* hold pdata->lock when call __afu_port_enable/disable */
> > -- 
> > 2.44.0
> > 
> >