linux-kernel - Re: [PATCH 13/13] mailbox: omap: Remove kernel FIFO message queuing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <761aa56f-55c4-e0d4-9f75-eef8035aa25b@ti.com>
Date: Mon, 1 Apr 2024 18:39:20 -0500
From: Hari Nagalla <hnagalla@...com>
To: Andrew Davis <afd@...com>, Jassi Brar <jassisinghbrar@...il.com>,
        Nick
 Saulnier <nsaulnier@...com>,
        Bjorn Andersson <andersson@...nel.org>,
        Mathieu
 Poirier <mathieu.poirier@...aro.org>
CC: <linux-remoteproc@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 13/13] mailbox: omap: Remove kernel FIFO message queuing

On 3/25/24 12:20, Andrew Davis wrote:
> The kernel FIFO queue has a couple issues. The biggest issue is that
> it causes extra latency in a path that can be used in real-time tasks,
> such as communication with real-time remote processors.
> 
> The whole FIFO idea itself looks to be a leftover from before the
> unified mailbox framework. The current mailbox framework expects
> mbox_chan_received_data() to be called with data immediately as it
> arrives. Remove the FIFO and pass the messages to the mailbox
> framework directly.
Yes, this would definitely speed up the message receive path. With RT 
linux, the irq runs in thread context, so that is Ok. But with non-RT 
the whole receive path runs in interrupt context. So, i think it would 
be appropriate to use a threaded_irq()?