linux-kernel - Re: [PATCH] scsi: qla2xxx: Fix off by one in qla_edif_app

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ABEE85CC-86A8-4DBB-A409-212834875E08@oracle.com>
Date: Tue, 2 Apr 2024 15:42:15 +0000
From: Himanshu Madhani <himanshu.madhani@...cle.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
CC: Quinn Tran <qutran@...vell.com>, Nilesh Javali <njavali@...vell.com>,
        "GR-QLogic-Storage-Upstream@...vell.com"
	<GR-QLogic-Storage-Upstream@...vell.com>,
        "James E.J. Bottomley"
	<jejb@...ux.ibm.com>,
        Martin Petersen <martin.petersen@...cle.com>,
        Larry
 Wisneski <Larry.Wisneski@...vell.com>,
        Duane Grigsby
	<duane.grigsby@...vell.com>,
        "linux-scsi@...r.kernel.org"
	<linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org"
	<kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] scsi: qla2xxx: Fix off by one in qla_edif_app_getstats()



> On Apr 2, 2024, at 02:56, Dan Carpenter <dan.carpenter@...aro.org> wrote:
> 
> The app_reply->elem[] array is allocated earlier in this function and it
> has app_req.num_ports elements.  Thus this > comparison needs to be >=
> to prevent memory corruption.
> 
> Fixes: 7878f22a2e03 ("scsi: qla2xxx: edif: Add getfcinfo and statistic bsgs")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
> drivers/scsi/qla2xxx/qla_edif.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_edif.c b/drivers/scsi/qla2xxx/qla_edif.c
> index 26e6b3e3af43..dcde55c8ee5d 100644
> --- a/drivers/scsi/qla2xxx/qla_edif.c
> +++ b/drivers/scsi/qla2xxx/qla_edif.c
> @@ -1100,7 +1100,7 @@ qla_edif_app_getstats(scsi_qla_host_t *vha, struct bsg_job *bsg_job)
> 
> list_for_each_entry_safe(fcport, tf, &vha->vp_fcports, list) {
> if (fcport->edif.enable) {
> - if (pcnt > app_req.num_ports)
> + if (pcnt >= app_req.num_ports)
> break;
> 
> app_reply->elem[pcnt].rekey_count =
> -- 
> 2.43.0
> 

Looks Good.

Reviewed-by: Himanshu Madhani <himanshu.madhani@...cle.com <mailto:himanshumadhani@...cle.com>>

-- 
Himanshu Madhani Oracle Linux Engineering