linux-kernel - Re: [PATCH 0/3] PCI/MSI: Remove IMS (Interrupt Message Store) support for now

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240402164204.GA1809883@bhelgaas>
Date: Tue, 2 Apr 2024 11:42:04 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: "Tian, Kevin" <kevin.tian@...el.com>
Cc: "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>, Marc Zyngier <maz@...nel.org>,
	"Chatre, Reinette" <reinette.chatre@...el.com>,
	Jason Gunthorpe <jgg@...dia.com>,
	Alex Williamson <alex.williamson@...hat.com>,
	"Jiang, Dave" <dave.jiang@...el.com>,
	Megha Dey <megha.dey@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH 0/3] PCI/MSI: Remove IMS (Interrupt Message Store)
 support for now

On Tue, Apr 02, 2024 at 02:45:50AM +0000, Tian, Kevin wrote:
> > From: Bjorn Helgaas <helgaas@...nel.org>
> > Sent: Tuesday, April 2, 2024 7:23 AM
> > 
> > From: Bjorn Helgaas <bhelgaas@...gle.com>
> > 
> > IMS (Interrupt Message Store) support appeared in v6.2, but there are no
> > users yet.
> > 
> > Remove it for now.  We can add it back when a user comes along.
> > 
> > Bjorn Helgaas (3):
> >   Revert "PCI/MSI: Provide stubs for IMS functions"
> >   Revert "PCI/MSI: Provide pci_ims_alloc/free_irq()"
> >   Revert "PCI/MSI: Provide IMS (Interrupt Message Store) support"
> > 
> 
> What about the other IMS related commits which are also dead
> code after above are reverted?
> 
> fa5745aca1dc ("iommu/amd: Enable PCI/IMS")
> 810531a1af53 ("iommu/vt-d: Enable PCI/IMS")
> 6e24c8877329 ("x86/apic/msi: Enable PCI/IMS")
> e23d4192bf9b ("genirq/msi: Provide constants for PCI/IMS support")

Thanks, I didn't catch those; will add in a v2.

Also, sorry for inadvertently sending this in the middle of an
unrelated thread.  I copied --in-reply-to from my notes when I
shouldn't have.

Bjorn