linux-kernel - Re: Re: [PATCH v9 15/15] selftests/sgx: Add scripts for EPC cgroup testing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yjremy4leipriqfd547wvjd6jt3r6t4tgz36eazy3slfuew4mc@v4iye7sm7yqn>
Date: Tue, 2 Apr 2024 19:40:03 +0200
From: Michal Koutný <mkoutny@...e.com>
To: Haitao Huang <haitao.huang@...ux.intel.com>
Cc: Jarkko Sakkinen <jarkko@...nel.org>, dave.hansen@...ux.intel.com, 
	tj@...nel.org, linux-kernel@...r.kernel.org, linux-sgx@...r.kernel.org, 
	x86@...nel.org, cgroups@...r.kernel.org, tglx@...utronix.de, mingo@...hat.com, 
	bp@...en8.de, hpa@...or.com, sohil.mehta@...el.com, tim.c.chen@...ux.intel.com, 
	zhiquan1.li@...el.com, kristen@...ux.intel.com, seanjc@...gle.com, zhanb@...rosoft.com, 
	anakrish@...rosoft.com, mikko.ylinen@...ux.intel.com, yangjie@...rosoft.com, 
	chrisyan@...rosoft.com
Subject: Re: Re: [PATCH v9 15/15] selftests/sgx: Add scripts for EPC cgroup
 testing

On Tue, Apr 02, 2024 at 11:20:21AM -0500, Haitao Huang <haitao.huang@...ux.intel.com> wrote:
> Do we really want to have it implemented in c?

I only pointed to the available C boilerplate.

> There are much fewer lines of
> code in shell scripts. Note we are not really testing basic cgroup stuff.
> All we needed were creating/deleting cgroups and set limits which I think
> have been demonstrated feasible in the ash scripts now.

I assume you refer to
Message-Id: <20240331174442.51019-1-haitao.huang@...ux.intel.com>
right?

Could it be even simpler if you didn't stick to cgtools APIs and v1
compatibility?

Reducing ash_cgexec.sh to something like
	echo 0 >$R/$1/cgroup.procs
	shift
	exec "$@"
(with some small builerplate for $R and previous mkdirs)


Thanks,
Michal

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)